[Bug tapsets/14549] New: probefunc and print_ustack changes cause lots of exelib.exp failures

[Bug tapsets/14549] New: probefunc and print_ustack changes cause lots of exelib.exp failures

[mjw at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14549

             Bug #: 14549
           Summary: probefunc and print_ustack changes cause lots of
                    exelib.exp failures
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
        AssignedTo: systemtap@sourceware.org
        ReportedBy: mjw@redhat.com
                CC: smakarov@redhat.com
    Classification: Unclassified


probefunc() and print_ustack() were recently changed causing lots of failures
in testsuite/systemtap.exelib/exelib.exp. Reverting this commit makes all
exelib.exp tests succeed again:

commit 4e4aaf10d022db0f607b9e729b1a7abd5decc1b4
Author: Serguei Makarov <smakarov@redhat.com>
Date:   Fri Aug 17 16:27:44 2012 -0400

    PR6580: rewrite simple to-be-deprecated backtrace functions in terms of new
ones

    For now, avoid changing backtrace(), probemod(), or the functions that
    depend on not running into MAXSTRINGLEN according to their documentation.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug tapsets/14549] probefunc and print_ustack changes cause lots of exelib.exp failures

[smakarov at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14549

--- Comment #1 from Serguei Makarov <smakarov at redhat dot com> 2012-09-06 14:15:59 UTC ---
Reverted relevant portions of the corresponding commit until I can figure out
what causes the regression.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug tapsets/14549] probefunc and print_ustack changes cause lots of exelib.exp failures

[smakarov at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14549

Serguei Makarov <smakarov at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Serguei Makarov <smakarov at redhat dot com> 2012-09-20 21:04:49 UTC ---
The current code in the repository passes exelib.exp with a rewritten
print_ustack(), but probefunc() has not been rewritten yet. The regression was
caused by the lack of support in commit 4e4aa for use of probefunc() in a
user-side probe. Knowing this, I should be able to avoid making that mistake
when rewriting probefunc() in future.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.