[Bug tapsets/15523] New: socket tapset broken

[Bug tapsets/15523] New: socket tapset broken

[dsmith at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15523

             Bug #: 15523
           Summary: socket tapset broken
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
        AssignedTo: systemtap@sourceware.org
        ReportedBy: dsmith@redhat.com
    Classification: Unclassified


On 3.7.0-0.36.el7.x86_64, the socket tapset has problems:

====
  $ cat test.stp
  probe socket.close {
        print(protocol)
        print(family)
        print(state)
        print(flags)
        print(type)
  }

  # stap -v test.stp
  <snip>
  Pass 5: starting run.
  ERROR: read fault [man error::fault] at 0x0000000000000128 (addr) near
identifier '$sock' at /usr/share/systemtap/tapset/linux/socket.stp:499:13
  1516183WARNING: Number of errors: 1, skipped probes: 1
  WARNING: /usr/bin/staprun exited with status: 1
====

The problem here is that the 'protocol' convenience variable is defined as the
following:

    protocol = $sock->sk->sk_protocol

In this case $sock->sk is NULL.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug tapsets/15523] socket tapset broken

[dsmith at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15523

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from David Smith <dsmith at redhat dot com> ---
Fixed in commit b53b293.

-- 
You are receiving this mail because:
You are the assignee for the bug.