[Bug testsuite/15703] New: map_hash.exp failures on rawhide because of gcc 'var-tracking-assignments' warning

[Bug testsuite/15703] New: map_hash.exp failures on rawhide because of gcc 'var-tracking-assignments' warning

[dsmith at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15703

            Bug ID: 15703
           Summary: map_hash.exp failures on rawhide because of gcc
                    'var-tracking-assignments' warning
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: systemtap at sourceware dot org
          Reporter: dsmith at redhat dot com

When running on rawhide (3.10.0-0.rc7.git0.2.fc20.x86_64 or
3.10.0-0.rc7.git0.2.fc20.i686.PAE),  I'm seeing the following errors when
running the map_hash.exp testcase:

====
Running ../../src/testsuite/systemtap.maps/map_hash.exp ...
FAIL: systemtap.maps/map_hash_SSI.stp
FAIL: systemtap.maps/map_hash_stat_II.stp
FAIL: systemtap.maps/map_hash_stat_SI.stp
FAIL: systemtap.maps/map_hash_stat_SSI.stp
====

Looking into systemtap.log, the test is failing because the testcase isn't
expecting a "note" from gcc about turning off '-fvar-tracking-assignments'.

====
executing: stap ../../src/testsuite/systemtap.maps/map_hash_SSI.stp
FAIL: systemtap.maps/map_hash_SSI.stp
line 2049: expected ""
Got "/tmp/stap0rL6w4/stap_5ad2b49b66e6b2aa0a6e21eb57d0903f_83857_src.c: In
function 'probe_2055':"
    "/tmp/stap0rL6w4/stap_5ad2b49b66e6b2aa0a6e21eb57d0903f_83857_src.c:6326:13:
note: variable tracking size limit exceeded with -fvar-tracking-assignments,
retrying without"
    " static void probe_2055 (struct context * __restrict__ c) {"
    "             ^"
====

I'm not sure of the best way of fixing these errors.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug testsuite/15703] map_hash.exp failures on rawhide because of gcc 'var-tracking-assignments' warning

[jistone at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15703

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jistone at redhat dot com

--- Comment #1 from Josh Stone <jistone at redhat dot com> ---
(In reply to David Smith from comment #0)
> I'm not sure of the best way of fixing these errors.

We don't generally care about debuginfo for our stap modules, so perhaps we can
just inject -fno-var-tracking-assignments?  Maybe with an environment control
or something for when we do care.

And not all gcc will support this, so it should be conditional with cc-option,
like we do when adding -Wframe-larger-than.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug testsuite/15703] map_hash.exp failures on rawhide because of gcc 'var-tracking-assignments' warning

[dsmith at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15703

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #2 from David Smith <dsmith at redhat dot com> ---
As I was about to test the following patch:

  // To avoid "note: variable tracking size limit exceeded with                 
  // -fvar-tracking-assignments" messages from gcc, turn off var                
  // tracking assignments. PR15703.                                             
  o << "EXTRA_CFLAGS += $(call cc-option,-fno-var-tracking-assignments)"        
    << endl;                                                                    

I realized this doesn't happen any more on rawhide
(3.11.0-0.rc3.git1.1.fc20.x86_64) with the following gcc:

gcc (GCC) 4.8.1 20130717 (Red Hat 4.8.1-5)

So, let's just close this for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.