[Bug tapsets/16730] New: stap -L '**' displays non-public probe points

[Bug tapsets/16730] New: stap -L '**' displays non-public probe points

[aferrazz at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16730

            Bug ID: 16730
           Summary: stap -L '**' displays non-public probe points
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
          Assignee: systemtap at sourceware dot org
          Reporter: aferrazz at redhat dot com

Running stap -L '**' currently shows probe points that are not user-accessible.
For example, one of the probes it outputs is begin(-1001), appearing as the
following:

begin(-1001) num:long

A pass 1 run of stap shows that this probe point is defined in
/usr/share/systemtap/tapset/linux/socket.stp, but is only used locally to that
script rather than being an alias definition. Also, the variable "num" is not
accessible to user scripts from within a begin(-1001) probe.

At the moment, begin(-1001) is only confirmed example of a non-public probe
point being listed, but it is possible that this problem extends beyond just
that case.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug tapsets/16730] stap -L '**' displays non-public probe points

[jistone at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16730

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jistone at redhat dot com

--- Comment #1 from Josh Stone <jistone at redhat dot com> ---
We talked a little on IRC, and I think this could be filtered by only listing
probes that have a derivation chain back to the user "script" made by -L.  That
begin probe in socket.stp stands on its own derivation, only pulled in because
it exists in the same file as another function/probe named in the user script.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug tapsets/16730] stap -L '**' displays non-public probe points

[jistone at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16730

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Josh Stone <jistone at redhat dot com> ---
Commit ede0102cfd2245b927c04bee3fab111c7c5b0a76 filters probes derived outside
of the user file.

Comparing before/after stap -L '**', I find that begin(-1001) is gone, and also
two rpc_create probes from tapset/linux/rpc.stp dealing with __rpc_create_args.

If there are any other "non-public" probes, they'll need a different test.

-- 
You are receiving this mail because:
You are the assignee for the bug.