[Bug tapsets/17462] New: aarch64 deprecates a number of syscalls (__NR_epoll_wait not defined)

[Bug tapsets/17462] New: aarch64 deprecates a number of syscalls (__NR_epoll_wait not defined)

[wcohen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17462

            Bug ID: 17462
           Summary: aarch64 deprecates a number of syscalls
                    (__NR_epoll_wait not defined)
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
          Assignee: systemtap at sourceware dot org
          Reporter: wcohen at redhat dot com

When running the pass1-4 tests on an aarch64 machine with:

# make installcheck RUNTESTFLAGS="--debug systemtap.pass1-4/*.exp"

A number of the tests fail like buildok/nd_syscalls-all-probes.stp:


spawn stap -wp4 ./buildok/nd_syscalls-all-probes.stp
/tmp/stapGoToEk/stap_ec0694ae78ebd3850fc11f783ae4a979_280860_src.c: In function 
'probe_2391':
/tmp/stapGoToEk/stap_ec0694ae78ebd3850fc11f783ae4a979_280860_src.c:32184:33:
err
or: '__NR_epoll_wait' undeclared (first use in this function)
           })) != ((((int64_t) ( __NR_epoll_wait ))))))) {
                                 ^
/tmp/stapGoToEk/stap_ec0694ae78ebd3850fc11f783ae4a979_280860_src.c:32184:33:
not
e: each undeclared identifier is reported only once for each function it
appears
 in
/tmp/stapGoToEk/stap_ec0694ae78ebd3850fc11f783ae4a979_280860_src.c: In function 
'probe_3061':
/tmp/stapGoToEk/stap_ec0694ae78ebd3850fc11f783ae4a979_280860_src.c:59603:33:
err
or: '__NR_epoll_wait' undeclared (first use in this function)
           })) != ((((int64_t) ( __NR_epoll_wait ))))))) {
                                 ^
make[3]: ***
[/tmp/stapGoToEk/stap_ec0694ae78ebd3850fc11f783ae4a979_280860_src.o
] Error 1
make[2]: *** [_module_/tmp/stapGoToEk] Error 2
WARNING: kbuild exited with status: 2
Pass 4: compilation failed.  [man error::pass4]
wait results: 27382 exp7 0 1
FAIL: buildok/nd_syscalls-all-probes.stp



On aarch64 the code ends up including
/usr/include/asm-generic/unistd.h.  This file effective has the definition of
__NR_epoll_wait disabled with:

#ifdef __ARCH_WANT_SYSCALL_DEPRECATED
...

#define __NR_epoll_wait 1069
__SYSCALL(__NR_epoll_wait, sys_epoll_wait)

...
#endif /* __ARCH_WANT_SYSCALL_DEPRECATED */

There are other defines surrounded by the
__ARCH_WANT_SYSCALL_DERPECATED in /usr/include/asm-generic/unistd.h in addition
to the __NR_epoll_wait that may need to be also addressed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug tapsets/17462] aarch64 deprecates a number of syscalls (__NR_epoll_wait not defined)

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17462

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dsmith at redhat dot com

--- Comment #1 from David Smith <dsmith at redhat dot com> ---
(In reply to William Cohen from comment #0)
> When running the pass1-4 tests on an aarch64 machine with:
> 
> # make installcheck RUNTESTFLAGS="--debug systemtap.pass1-4/*.exp"
> 
> A number of the tests fail like buildok/nd_syscalls-all-probes.stp:
> 
> 
> spawn stap -wp4 ./buildok/nd_syscalls-all-probes.stp
> /tmp/stapGoToEk/stap_ec0694ae78ebd3850fc11f783ae4a979_280860_src.c: In
> function 
> 'probe_2391':
> /tmp/stapGoToEk/stap_ec0694ae78ebd3850fc11f783ae4a979_280860_src.c:32184:33:
> err
> or: '__NR_epoll_wait' undeclared (first use in this function)
>            })) != ((((int64_t) ( __NR_epoll_wait ))))))) {
>                                  ^

The solution here is to add __NR_epoll_wait to
src/runtime/linux/compat_unistd.h, like this:

====
#ifndef __NR_epoll_wait
#define __NR_epoll_wait (__NR_syscall_max + 1)
#endif
====

There is a section of defines like that at the top of that file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug tapsets/17462] aarch64 deprecates a number of syscalls (__NR_epoll_wait not defined)

[wcohen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17462

William Cohen <wcohen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from William Cohen <wcohen at redhat dot com> ---
Applied dsmith's suggestion and it eliminates 6 of the pass1-4 failures.

-- 
You are receiving this mail because:
You are the assignee for the bug.