[Bug runtime/17894] New: global_opt_unknown.exp failure

[Bug runtime/17894] New: global_opt_unknown.exp failure

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17894

            Bug ID: 17894
           Summary: global_opt_unknown.exp failure
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: mcermak at redhat dot com

The global_opt_unknown.exp testcase fails in kernel runtime on rhel[567] all
arches. In dyninst mode we get expected warning:

=======
 # stap -G var2=29 -e 'global var1=9 ; probe begin { if (var1 == 9)
println("systemtap test success") else println("systemtap test failure") ;
exit()} ' --dyninst
stapdyn: WARNING: Ignoring unknown module option 'var2'
systemtap test success
=======

But using kernel runtime, "Unknown symbol in module" occures:

=======
 7.1 S x86_64 [-] # stap -vv -G var2=29 -e 'global var1=9 ; probe begin { if
(var1 == 9) println("systemtap test success") else println("systemtap test
failure") ; exit()} '
Systemtap translator/driver (version 2.7/0.160, commit
release-2.6-175-g7be1b19f9898 + changes)
Copyright (C) 2005-2014 Red Hat, Inc. and others
This is free software; see the source for copying conditions.
enabled features: AVAHI LIBRPM LIBSQLITE3 NSS BOOST_SHARED_PTR
TR1_UNORDERED_MAP NLS DYNINST JAVA LIBVIRT LIBXML2
Created temporary directory "/tmp/stapREtnmb"
Session arch: x86_64 release: 3.10.0-224.el7.x86_64
Searched for library macro files:
"/root/mcermak-systemtap/systemtap-build/share/systemtap/tapset/linux/*.stpm",
found: 3, processed: 3
Searched for library macro files:
"/root/mcermak-systemtap/systemtap-build/share/systemtap/tapset/*.stpm", found:
5, processed: 5
Searched:
"/root/mcermak-systemtap/systemtap-build/share/systemtap/tapset/linux/x86_64/*.stp",
found: 3, processed: 3
Searched:
"/root/mcermak-systemtap/systemtap-build/share/systemtap/tapset/linux/*.stp",
found: 70, processed: 70
Searched:
"/root/mcermak-systemtap/systemtap-build/share/systemtap/tapset/x86_64/*.stp",
found: 1, processed: 1
Searched:
"/root/mcermak-systemtap/systemtap-build/share/systemtap/tapset/*.stp", found:
24, processed: 24
Pass 1: parsed user script and 106 library script(s) using
216032virt/33432res/3076shr/30904data kb, in 110usr/20sys/130real ms.
Pass 2: analyzed script: 1 probe(s), 1 function(s), 0 embed(s), 1 global(s)
using 216560virt/34484res/3344shr/31432data kb, in 10usr/0sys/4real ms.
Pass 3: using cached
/root/.systemtap/cache/91/stap_910fd4e2e09a713d1ee09e21c6b0d6e9_1248.c
Pass 4: using cached
/root/.systemtap/cache/91/stap_910fd4e2e09a713d1ee09e21c6b0d6e9_1248.ko
Pass 5: starting run.
Running /root/mcermak-systemtap/systemtap-build/bin/staprun -v -R
/tmp/stapREtnmb/stap_910fd4e2e09a713d1ee09e21c6b0d6e9_1248.ko var2=29
staprun:insert_module:183 Module stap_910fd4e2e09a713d1ee09e21c6b0d6e_27789
inserted from file
/tmp/stapREtnmb/stap_910fd4e2e09a713d1ee09e21c6b0d6e9_1248.ko
ERROR: Couldn't insert module
'/tmp/stapREtnmb/stap_910fd4e2e09a713d1ee09e21c6b0d6e9_1248.ko': Unknown symbol
in module
Spawn waitpid result (0x100): 1
WARNING: /root/mcermak-systemtap/systemtap-build/bin/staprun exited with
status: 1
Pass 5: run completed in 0usr/0sys/8real ms.
Pass 5: run failed.  [man error::pass5]
Running rm -rf /tmp/stapREtnmb
Spawn waitpid result (0x0): 0
Removed temporary directory "/tmp/stapREtnmb"
=======

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/17894] global_opt_unknown.exp failure

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17894

Martin Cermak <mcermak at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jistone at redhat dot com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/17894] global_opt_unknown.exp failure

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17894

--- Comment #1 from Martin Cermak <mcermak at redhat dot com> ---
Apparently, what causes the problem, is passing that `var2` parameter:

=======
 7.1 S x86_64 [-] # /root/mcermak-systemtap/systemtap-build/bin/staprun -R
/tmp/stapqcf3CF/stap_27792.ko var2=29
ERROR: Couldn't insert module '/tmp/stapqcf3CF/stap_27792.ko': Unknown symbol
in module
=======

Without the parameter, the module inserts fine:

=======
 7.1 S x86_64 [-] # /root/mcermak-systemtap/systemtap-build/bin/staprun -R
/tmp/stapqcf3CF/stap_27792.ko
systemtap test success
=======

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/17894] global_opt_unknown.exp failure

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17894

--- Comment #2 from Martin Cermak <mcermak at redhat dot com> ---
So looking at PR17858, we now have inconsistent behavior between kernel and
dyninst runtimes in case an unknown parameter gets passed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/17894] global_opt_unknown.exp failure

[jistone at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17894

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #3 from Josh Stone <jistone at redhat dot com> ---
Hmm, rhel kernels must have tighter rules.  On Fedora 21 I just get in dmesg:
  stap_9855fa30e87968f12b21cc61062bd97_14264: unknown parameter 'var2' ignored

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/17894] global_opt_unknown.exp failure

[jistone at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17894

--- Comment #4 from Josh Stone <jistone at redhat dot com> ---
Ah, ignoring is relatively new behavior:

54041d8a7333 modules: don't fail to load on unknown parameters.
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=54041d8a73337411b485ff76957fb106cb5d40d0

$ git describe --contains 54041d8a7333
v3.11-rc1~44^2~2

(In reply to Martin Cermak from comment #2)
> So looking at PR17858, we now have inconsistent behavior between kernel and
> dyninst runtimes in case an unknown parameter gets passed.

Given that kernels are now inconsistent, this can't be helped.  I think it's
best to keep the dyninst runtime following newer kernels, but I'll see about
tweaking the test for kernels prior to 3.11.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/17894] global_opt_unknown.exp failure

[jistone at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17894

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Josh Stone <jistone at redhat dot com> ---
Fixed in commit 74012fb62ab9 - kernel < 3.11 is marked unsupported for this
test.

-- 
You are receiving this mail because:
You are the assignee for the bug.