[Bug translator/18461] New: The code generated by tapset-netfilter.cxx for nf_hook_ops does not compile with linux-4.1.0-rc5 kernel

[Bug translator/18461] New: The code generated by tapset-netfilter.cxx for nf_hook_ops does not compile with linux-4.1.0-rc5 kernel

[wcohen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18461

            Bug ID: 18461
           Summary: The code generated by tapset-netfilter.cxx for
                    nf_hook_ops does not compile with linux-4.1.0-rc5
                    kernel
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
          Assignee: systemtap at sourceware dot org
          Reporter: wcohen at redhat dot com
  Target Milestone: ---

When reviewing the test resuts on an arm machine runing a linux-4.1-rc5 kernel
a number of the tests such as netfilter_summary_json.stp fail to compile. 
Below is a example output from from the systemtap.log:

TEST
PWD=/run/media/wcohen/wasteland/wcohen/systemtap_write/systemtap/testsuite/systemtap.examples/network
meta taglines 'test_check: stap -g -p4 netfilter_drop.stp TCP 1' tag
'test_check' value 'stap -g -p4 netfilter_drop.stp TCP 1'
attempting command stap -g -p4 netfilter_drop.stp TCP 1
OUT /tmp/stapEqKFr7/stap_74a85d0b748d91faedb84473b46a3398_14384_src.c:2709:1:
error: initialization from incompatible pointer type [-Werror]
 .hook = enter_netfilter_probe_0,
 ^
/tmp/stapEqKFr7/stap_74a85d0b748d91faedb84473b46a3398_14384_src.c:2709:1:
error: (near initialization for 'netfilter_opts_0.hook') [-Werror]
cc1: all warnings being treated as errors
make[4]: ***
[/tmp/stapEqKFr7/stap_74a85d0b748d91faedb84473b46a3398_14384_src.o] Error 1
make[3]: *** [_module_/tmp/stapEqKFr7] Error 2
WARNING: kbuild exited with status: 2
Pass 4: compilation failed.  [man error::pass4]
child process exited abnormally
RC 1
FAIL: ./systemtap.examples/network/netfilter_drop build


The problem looks to be caused by the typedef for nf_hook_fn in
include/linux/netfilter.h being changed in the kernel by the following commit:

Author: David S. Miller <davem@davemloft.net>  2015-04-03 20:32:56
Committer: David S. Miller <davem@davemloft.net>  2015-04-04 12:31:38
Parent: 1d1de89b9a4746f1dd055a3b8d073dd2f962a3b6 (netfilter: Use nf_hook_state
in nf_queue_entry.)
Child:  d7cf4081ed454dba02cb632e492ecf5e29d1ee44 (netfilter: Pass nf_hook_state
through nf_nat_ipv4_{in,out,fn,local_fn}().)
Branches: master, remotes/origin/master
Follows: v4.0-rc6
Precedes: v4.1-rc1

    netfilter: Make nf_hookfn use nf_hook_state.

    Pass the nf_hook_state all the way down into the hook
    functions themselves.

    Signed-off-by: David S. Miller <davem@davemloft.net>

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/18461] The code generated by tapset-netfilter.cxx for nf_hook_ops does not compile with linux-4.1.0-rc5 kernel

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18461

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |dsmith at redhat dot com
         Resolution|---                         |FIXED

--- Comment #1 from David Smith <dsmith at redhat dot com> ---
Fixed in commit 502f381.

-- 
You are receiving this mail because:
You are the assignee for the bug.