[Bug translator/19236] New: NULL global variable breakage

[Bug translator/19236] New: NULL global variable breakage

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19236

            Bug ID: 19236
           Summary: NULL global variable breakage
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
          Assignee: systemtap at sourceware dot org
          Reporter: mcermak at redhat dot com
                CC: jistone at redhat dot com
  Target Milestone: ---

Created attachment 8779
  --> https://sourceware.org/bugzilla/attachment.cgi?id=8779&action=edit
proposed patch

One private feature related thing I didn't notice earlier is following failure
of the null buildok testcase:

=======
#  stap -e 'probe begin { println(NULL) }'  |&  head
In file included from include/linux/module.h:17:0,
                 from /usr/local/share/systemtap/runtime/linux/runtime.h:14,
                 from /usr/local/share/systemtap/runtime/runtime.h:24,
                 from
/tmp/stapZoovRF/stap_f8cdd473c043e55c42c181392132b9c4_903_src.c:25:
include/linux/moduleparam.h:338:22: error: pasting "__check_" and "(" does not
give a valid preprocessing token
  static inline type *__check_##name(void) { return(p); }
                      ^
/usr/local/share/systemtap/runtime/linux/runtime.h:276:38: note: in expansion
of macro ‘__param_check’
 #define param_check_int64_t(name, p) __param_check(name, p, int64_t)
                                      ^
# 
=======

Bisecting the source shows it's related to commit
6b15a04af5b6904c750c1878a965032a906c4874. Looking at the very end of the -p3
output I see this:

=======
#  stap -p3 -e 'probe begin { println(NULL) }' |& tail -n 2
#undef __global_NULL
module_param_named (NULL, global(s___global_NULL), int64_t, 0);
# 
=======

Attached patch fixes the issue for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/19236] NULL global variable breakage

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19236

Martin Cermak <mcermak at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Martin Cermak <mcermak at redhat dot com> ---
Fixed in commit eba95df1db7f6a0828f55dfb05729d799f825767

-- 
You are receiving this mail because:
You are the assignee for the bug.