[Bug runtime/19915] New: flight recorder's "logrorate" feature broken

[Bug runtime/19915] New: flight recorder's "logrorate" feature broken

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19915

            Bug ID: 19915
           Summary: flight recorder's "logrorate" feature broken
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: mcermak at redhat dot com
  Target Milestone: ---

With latest git stap, the flight recorder's "logrotate" feature is broken:

=======
# cd `mktemp -d`; stap --poison-cache -F -o flightlog.out -S 1,3 -b -e 'probe
kprobe.function("update_process_times") { for (j = 0; j < 100; j++)
printf("1234567890\n") }'; sleep 30; ls -lh
26999
total 23M
-rw-r--r--. 1 root root 8.0M Apr  6 12:18 flightlog.out_cpu0.0
-rw-r--r--. 1 root root 1.8M Apr  6 12:18 flightlog.out_cpu1.0
-rw-r--r--. 1 root root 8.0M Apr  6 12:18 flightlog.out_cpu2.0
-rw-r--r--. 1 root root 4.8M Apr  6 12:18 flightlog.out_cpu3.0
# kill 26999
=======

Note that due to -S 1,3 the log size shouldn't exceed 1M. Git bisect shows that
a1d9dcb556ada46de8ba87e3e55c6aab7ff480e4 (monitor mode: staprun revamp) is the
first bad commit.

Note that the testcase that detected this is flightrec3.exp. But the detection
is unreliable, since the sleep() used is not long enough for stap to generate
enough logs. Now the testcase mostly generates false passes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/19915] flight recorder's "logrorate" feature broken

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19915

--- Comment #1 from Martin Cermak <mcermak at redhat dot com> ---
Created attachment 9157
  --> https://sourceware.org/bugzilla/attachment.cgi?id=9157&action=edit
proposed patch

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/19915] flight recorder's "logrorate" feature broken

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19915

Martin Cermak <mcermak at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Martin Cermak <mcermak at redhat dot com> ---
Fixed in commit 51eb53e (using an updated patch).

-- 
You are receiving this mail because:
You are the assignee for the bug.