public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* [Bug runtime/20065] New: Configure script is not in sync with configure.ac
@ 2016-05-09 20:36 francis.giraldeau at gmail dot com
  2016-05-09 20:56 ` [Bug runtime/20065] " jistone at redhat dot com
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: francis.giraldeau at gmail dot com @ 2016-05-09 20:36 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=20065

            Bug ID: 20065
           Summary: Configure script is not in sync with configure.ac
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: francis.giraldeau at gmail dot com
  Target Milestone: ---

It seems that the configure.ac file in the repo is newer than configure script.
After regenerate it with "autoreconf -vfi", I get the following error:

./configure
[...]
./configure: line 9443: syntax error near unexpected token `11,'
./configure: line 9443: `AX_CXX_COMPILE_STDCXX(11, noext, optional)'

It seems some m4 macros are missing:

https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html
http://www.gnu.org/software/autoconf-archive/ax_check_compile_flag.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug runtime/20065] Configure script is not in sync with configure.ac
  2016-05-09 20:36 [Bug runtime/20065] New: Configure script is not in sync with configure.ac francis.giraldeau at gmail dot com
@ 2016-05-09 20:56 ` jistone at redhat dot com
  2016-05-09 21:19 ` jistone at redhat dot com
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: jistone at redhat dot com @ 2016-05-09 20:56 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=20065

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jistone at redhat dot com

--- Comment #1 from Josh Stone <jistone at redhat dot com> ---
(In reply to Francis Giraldeau from comment #0)
> It seems that the configure.ac file in the repo is newer than configure
> script. After regenerate it with "autoreconf -vfi", I get the following
> error:
> 
> ./configure
> [...]
> ./configure: line 9443: syntax error near unexpected token `11,'
> ./configure: line 9443: `AX_CXX_COMPILE_STDCXX(11, noext, optional)'

This succeeds for me on Fedora 23, with no new changes.

(Well, a couple makefiles have shuffled install lines, but these seem to shift
every time I regenerate them.)

> It seems some m4 macros are missing:
> 
> https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html
> http://www.gnu.org/software/autoconf-archive/ax_check_compile_flag.html

For some reason, these two macros were put in aclocal.m4 instead of under the
m4/ directory.  I don't know how to influence that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug runtime/20065] Configure script is not in sync with configure.ac
  2016-05-09 20:36 [Bug runtime/20065] New: Configure script is not in sync with configure.ac francis.giraldeau at gmail dot com
  2016-05-09 20:56 ` [Bug runtime/20065] " jistone at redhat dot com
@ 2016-05-09 21:19 ` jistone at redhat dot com
  2016-05-09 21:48 ` francis.giraldeau at gmail dot com
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: jistone at redhat dot com @ 2016-05-09 21:19 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=20065

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING

--- Comment #2 from Josh Stone <jistone at redhat dot com> ---
OK, I ran "aclocal -Im4 --install", and those missing files are now in the m4/
directory.  Can you see if branch "jistone/pr20065" works for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug runtime/20065] Configure script is not in sync with configure.ac
  2016-05-09 20:36 [Bug runtime/20065] New: Configure script is not in sync with configure.ac francis.giraldeau at gmail dot com
  2016-05-09 20:56 ` [Bug runtime/20065] " jistone at redhat dot com
  2016-05-09 21:19 ` jistone at redhat dot com
@ 2016-05-09 21:48 ` francis.giraldeau at gmail dot com
  2016-05-09 22:09 ` jistone at redhat dot com
  2016-05-09 22:09 ` jistone at redhat dot com
  4 siblings, 0 replies; 6+ messages in thread
From: francis.giraldeau at gmail dot com @ 2016-05-09 21:48 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=20065

--- Comment #3 from Francis Giraldeau <francis.giraldeau at gmail dot com> ---
(In reply to Josh Stone from comment #2)
> OK, I ran "aclocal -Im4 --install", and those missing files are now in the
> m4/ directory.  Can you see if branch "jistone/pr20065" works for you?

I confirm that the change fixes the issue. Thanks!

As a side note: these generated files (configure, Makefile.in, etc.) are
usually not added to the repo. Instead, they could be generated locally after
checkout. It would ensure that configure.ac is always in sync with other
generated files and avoid the noise related to Makefile.in changes. The
generated files can be shipped as part of release tarballs to simplify the
installation procedure for the users.

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug runtime/20065] Configure script is not in sync with configure.ac
  2016-05-09 20:36 [Bug runtime/20065] New: Configure script is not in sync with configure.ac francis.giraldeau at gmail dot com
                   ` (3 preceding siblings ...)
  2016-05-09 22:09 ` jistone at redhat dot com
@ 2016-05-09 22:09 ` jistone at redhat dot com
  4 siblings, 0 replies; 6+ messages in thread
From: jistone at redhat dot com @ 2016-05-09 22:09 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=20065

--- Comment #4 from Josh Stone <jistone at redhat dot com> ---
(In reply to Francis Giraldeau from comment #3)
> I confirm that the change fixes the issue. Thanks!

Thanks for confirming -- I pushed this to master.
commit 5ad0fbcaf80f22e64aa35eda3326fa233a1802b9

> As a side note: these generated files (configure, Makefile.in, etc.) are
> usually not added to the repo. Instead, they could be generated locally
> after checkout. It would ensure that configure.ac is always in sync with
> other generated files and avoid the noise related to Makefile.in changes.
> The generated files can be shipped as part of release tarballs to simplify
> the installation procedure for the users.

Yes, it's a trade-off.  We do it this way so anyone can work on systemtap from
git sources, without having the autotools installed.  It's relatively rare that
one needs to modify these generated files.

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug runtime/20065] Configure script is not in sync with configure.ac
  2016-05-09 20:36 [Bug runtime/20065] New: Configure script is not in sync with configure.ac francis.giraldeau at gmail dot com
                   ` (2 preceding siblings ...)
  2016-05-09 21:48 ` francis.giraldeau at gmail dot com
@ 2016-05-09 22:09 ` jistone at redhat dot com
  2016-05-09 22:09 ` jistone at redhat dot com
  4 siblings, 0 replies; 6+ messages in thread
From: jistone at redhat dot com @ 2016-05-09 22:09 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=20065

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-05-09 22:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-09 20:36 [Bug runtime/20065] New: Configure script is not in sync with configure.ac francis.giraldeau at gmail dot com
2016-05-09 20:56 ` [Bug runtime/20065] " jistone at redhat dot com
2016-05-09 21:19 ` jistone at redhat dot com
2016-05-09 21:48 ` francis.giraldeau at gmail dot com
2016-05-09 22:09 ` jistone at redhat dot com
2016-05-09 22:09 ` jistone at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).