[Bug runtime/20122] New: use base os toolchain consistently in the developer toolset environment

[Bug runtime/20122] New: use base os toolchain consistently in the developer toolset environment

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20122

            Bug ID: 20122
           Summary: use base os toolchain consistently in the developer
                    toolset environment
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: mcermak at redhat dot com
  Target Milestone: ---

In the devtoolset environment, base os compiler is being used even if the
devtoolset one is available.  This way systemtap kernel modules are being
compiled using similar compiler to which has been used for the kernel
compilation.  Systemtap enforces that by tweaking the PATH env var
appropriately.

However it turns out that LD_LIBRARY_PATH isn't being updated accordingly and
so the base rhel assembler uses the devtoolset variant of bfd, which leads to
rhbz1337617.

Following update fixes this problem for me:

=======
# git diff
diff --git a/buildrun.cxx b/buildrun.cxx
index 0656e70..9621c97 100644
--- a/buildrun.cxx
+++ b/buildrun.cxx
@@ -101,11 +101,19 @@ make_any_make_cmd(systemtap_session& s, const string&
dir, const string& target)
       newpath += oldpath;
     }

+  string newldlpath("LD_LIBRARY_PATH=/usr/lib64:/usr/lib");
+  const char *oldldlpath = getenv("LD_LIBRARY_PATH");
+  if (oldldlpath != NULL)
+    {
+      newldlpath += ':';
+      newldlpath += oldldlpath;
+    }
+
   vector<string> make_cmd
     {
       // PR14168: sanitize environment variables for kbuild invocation
       "env", "-uARCH", "-uKBUILD_EXTMOD", "-uCROSS_COMPILE", "-uKBUILD_IMAGE",
-      "-uKCONFIG_CONFIG", "-uINSTALL_PATH", newpath,
+      "-uKCONFIG_CONFIG", "-uINSTALL_PATH", newpath, newldlpath,

       "make", "-C", s.kernel_build_tree,
       "M=" + dir, // need make-quoting?
#
=======

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/20122] use base os toolchain consistently in the developer toolset environment

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20122

Martin Cermak <mcermak at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Martin Cermak <mcermak at redhat dot com> ---
Fixed in commit 37a4150fe4ace4af2d8335442feb91f5bb06d91e

-- 
You are receiving this mail because:
You are the assignee for the bug.