public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* [Bug runtime/20131] New: listing_mode.exp wildcard library path failures
@ 2016-05-23 15:46 dsmith at redhat dot com
  2016-05-23 16:44 ` [Bug runtime/20131] " jistone at redhat dot com
  2016-05-26 19:22 ` dsmith at redhat dot com
  0 siblings, 2 replies; 3+ messages in thread
From: dsmith at redhat dot com @ 2016-05-23 15:46 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=20131

            Bug ID: 20131
           Summary: listing_mode.exp wildcard library path failures
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: dsmith at redhat dot com
  Target Milestone: ---

For a long while now, listing_mode.exp has had lots of failures. Commit 79be36d
improves the situation by making the test be more forgiving about 'stap -l'
output. There were times the test was expecting a full library path in the
output where 'stap -l' was outputting a relative path.

Originally, we were getting the following test numbers:

rhel6: 747 passes / 728 failures / 60 untested
rhel7: 899 passes / 792 failures / 36 untested
f23:   899 passes / 792 failures / 36 untested

With commit 79be36d, I'm getting:

rhel6: 1279 passes / 184 failures / 72 untested
rhel7: 1431 passes / 260 failures / 36 untested
f23:   1431 passes / 260 failures / 36 untested

So, where are the remaining failures coming from? Some are coming from bug
#18083 (listing_mode.exp fails on rhel6), related to line number problems.

The majority however are related to the following bug. At some point the
finding libraries using a wildcard stopped working, such as the following
command:

# stap -l process.library("*liblisting_mode.so").function("*") -c listing_mode

The function stap_list_cmd_lib in listing_mode.exp tries to find libraries 4
different ways: using a simple name ('.library("liblisting_mode.so")'), using a
relative name ('.library("./liblisting_mode.so")'), using the full path to the
library ('.library("/FOO/BAR/liblisting_mode.so")'), and using a wildcard
('.library("*liblisting_mode.so")'). Only the last variant fails.

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug runtime/20131] listing_mode.exp wildcard library path failures
  2016-05-23 15:46 [Bug runtime/20131] New: listing_mode.exp wildcard library path failures dsmith at redhat dot com
@ 2016-05-23 16:44 ` jistone at redhat dot com
  2016-05-26 19:22 ` dsmith at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: jistone at redhat dot com @ 2016-05-23 16:44 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=20131

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jistone at redhat dot com

--- Comment #1 from Josh Stone <jistone at redhat dot com> ---
This looks like the same issue that I found when I reopened PR17231.  But I'll
close that one in favor of your more specific bug tracked here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug runtime/20131] listing_mode.exp wildcard library path failures
  2016-05-23 15:46 [Bug runtime/20131] New: listing_mode.exp wildcard library path failures dsmith at redhat dot com
  2016-05-23 16:44 ` [Bug runtime/20131] " jistone at redhat dot com
@ 2016-05-26 19:22 ` dsmith at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: dsmith at redhat dot com @ 2016-05-26 19:22 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=20131

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from David Smith <dsmith at redhat dot com> ---
Fixed in commit 4e4b08e. With this commit, I'm seeing the following test
results:

rhel6:   1431 passes / 32 failures
rhel7:   1691 passes /  0 failures
rawhide: 1691 passes /  0 failures

The rhel6 failures all seem to be from bug #18083.

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-05-26 19:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-23 15:46 [Bug runtime/20131] New: listing_mode.exp wildcard library path failures dsmith at redhat dot com
2016-05-23 16:44 ` [Bug runtime/20131] " jistone at redhat dot com
2016-05-26 19:22 ` dsmith at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).