* [Bug testsuite/20298] New: the unprivileged_embedded_C.exp testcase needs updating
@ 2016-06-24 18:10 dsmith at redhat dot com
2016-06-27 17:57 ` [Bug testsuite/20298] " dsmith at redhat dot com
0 siblings, 1 reply; 2+ messages in thread
From: dsmith at redhat dot com @ 2016-06-24 18:10 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=20298
Bug ID: 20298
Summary: the unprivileged_embedded_C.exp testcase needs
updating
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: testsuite
Assignee: systemtap at sourceware dot org
Reporter: dsmith at redhat dot com
Target Milestone: ---
There are at least 2 problems I see with
testsuite/systemtap.stress/unprivileged_embedded_C.exp:
1) It only searches tapset functions in tapset/ and tapset/${ARCH}/. It doesn't
search tapsets in tapset/linux/ and tapset/linux/${ARCH}/. It needs to be
updated for the dyninst/linux tapset directory rearrangement.
2) It gets spurious failures. It assumes that if a tapset function doesn't have
any embedded C (i.e. a pure stap script function), a unprivileged user can call
it. That isn't the case if that pure stap script function calls a function that
is privileged.
For example, note the following 2 functions from tapset/linux/conversions.exp:
====
function kernel_string:string (addr:long) %{ /* pure */
...
%}
function kernel_string:string (addr:long, err_msg:string) {
try { return kernel_string(addr) } catch { return err_msg }
}
====
If unprivileged_embedded_C.exp tests the 2nd function above, it will think an
unprivileged user should be able to call it. However, since it calls the 1st
function which is privileged, the 2nd function is also privileged.
Since the testcase can't know what pure stap script functions should be
privileged or unprivileged, it should probably just skip testing them.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug testsuite/20298] the unprivileged_embedded_C.exp testcase needs updating
2016-06-24 18:10 [Bug testsuite/20298] New: the unprivileged_embedded_C.exp testcase needs updating dsmith at redhat dot com
@ 2016-06-27 17:57 ` dsmith at redhat dot com
0 siblings, 0 replies; 2+ messages in thread
From: dsmith at redhat dot com @ 2016-06-27 17:57 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=20298
David Smith <dsmith at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from David Smith <dsmith at redhat dot com> ---
Fixed in commit ec0920c.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-27 17:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-24 18:10 [Bug testsuite/20298] New: the unprivileged_embedded_C.exp testcase needs updating dsmith at redhat dot com
2016-06-27 17:57 ` [Bug testsuite/20298] " dsmith at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).