[Bug tapsets/21102] New: the ioblock.stp tapset needs to be updated

[Bug tapsets/21102] New: the ioblock.stp tapset needs to be updated

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21102

            Bug ID: 21102
           Summary: the ioblock.stp tapset needs to be updated
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
          Assignee: systemtap at sourceware dot org
          Reporter: dsmith at redhat dot com
  Target Milestone: ---

The ioblock.stp tapset, when used on rawhide (4.10.0-0.rc6.git0.1.fc26.x86_64),
has several problems because of upstream kernel changes:

====
# stap -p4 /systemtap/src/testsuite/buildok/ioblock-detailed.stp
semantic error: while processing probe
kernel.function("generic_make_request@block/blk-core.c:1978") from:
ioblock.request from: ioblock.request

semantic error: unable to find member 'bi_rw' for struct bio (alternatives:
bi_css, bi_ioc, bi_opf, __bi_cnt, bi_bdev, bi_error, bi_iter, bi_next, bi_pool,
bi_vcnt, bi_flags, bi_ioprio, bi_end_io, bi_io_vec, bi_private, bi_integrity,
bi_max_vecs, __bi_remaining, bi_inline_vecs, bi_seg_back_size,
bi_phys_segments, bi_seg_front_size): operator '->' at
/usr/local/share/systemtap/tapset/linux/ioblock.stp:113:18
        source:         rw = $bio->bi_rw
                                 ^

semantic error: unable to find member 'bi_rw' for struct bio (alternatives:
bi_css, bi_ioc, bi_opf, __bi_cnt, bi_bdev, bi_error, bi_iter, bi_next, bi_pool,
bi_vcnt, bi_flags, bi_ioprio, bi_end_io, bi_io_vec, bi_private, bi_integrity,
bi_max_vecs, __bi_remaining, bi_inline_vecs, bi_seg_back_size,
bi_phys_segments, bi_seg_front_size): operator '->' at :113:18
        source:         rw = $bio->bi_rw
                                 ^

semantic error: unable to find member 'bi_rw' for struct bio (alternatives:
bi_css, bi_ioc, bi_opf, __bi_cnt, bi_bdev, bi_error, bi_iter, bi_next, bi_pool,
bi_vcnt, bi_flags, bi_ioprio, bi_end_io, bi_io_vec, bi_private, bi_integrity,
bi_max_vecs, __bi_remaining, bi_inline_vecs, bi_seg_back_size,
bi_phys_segments, bi_seg_front_size): operator '->' at :113:18
        source:         rw = $bio->bi_rw
                                 ^

semantic error: unable to find member 'bi_rw' for struct bio (alternatives:
bi_css, bi_ioc, bi_opf, __bi_cnt, bi_bdev, bi_error, bi_iter, bi_next, bi_pool,
bi_vcnt, bi_flags, bi_ioprio, bi_end_io, bi_io_vec, bi_private, bi_integrity,
bi_max_vecs, __bi_remaining, bi_inline_vecs, bi_seg_back_size,
bi_phys_segments, bi_seg_front_size): operator '->' at :113:18
        source:         rw = $bio->bi_rw
                                 ^

semantic error: unable to find member 'bi_rw' for struct bio (alternatives:
bi_css, bi_ioc, bi_opf, __bi_cnt, bi_bdev, bi_error, bi_iter, bi_next, bi_pool,
bi_vcnt, bi_flags, bi_ioprio, bi_end_io, bi_io_vec, bi_private, bi_integrity,
bi_max_vecs, __bi_remaining, bi_inline_vecs, bi_seg_back_size,
bi_phys_segments, bi_seg_front_size): operator '->' at :113:18
        source:         rw = $bio->bi_rw
                                 ^

Pass 2: analysis failed.  [man error::pass2]
====

====
# stap -p4 --compatible=2.9
/systemtap/src/testsuite/buildok/ioblock-embedded.stp
/tmp/stapysOHok/stap_e4e5d8a23b62e8a72c23e0210a78481c_12610_src.c: In function
'function___global_bio_rw_num__overload_0':
/tmp/stapysOHok/stap_e4e5d8a23b62e8a72c23e0210a78481c_12610_src.c:1054:89:
error: 'REQ_WRITE' undeclared (first use in this function); did you mean
'REQ_OP_WRITE'?
 >l_rw) & ((((int64_t) (/* pure */ /* unprivileged */ /* stable */
REQ_WRITE)))));
                                                                   ^~~~~~~~~
                                                                               
         REQ_OP_WRITE
/tmp/stapysOHok/stap_e4e5d8a23b62e8a72c23e0210a78481c_12610_src.c:1054:89:
note: each undeclared identifier is reported only once for each function it
appears in
make[4]: *** [scripts/Makefile.build:293:
/tmp/stapysOHok/stap_e4e5d8a23b62e8a72c23e0210a78481c_12610_src.o] Error 1
make[3]: *** [Makefile:1494: _module_/tmp/stapysOHok] Error 2
WARNING: kbuild exited with status: 2
Pass 4: compilation failed.  [man error::pass4]
====

The tapset should be updated.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug tapsets/21102] the ioblock.stp tapset needs to be updated

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21102

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from David Smith <dsmith at redhat dot com> ---
Commit 81f884b updates the ioblock tapset.

-- 
You are receiving this mail because:
You are the assignee for the bug.