* [Bug uprobes/21238] New: Failed user probing does not return proper error
@ 2017-03-09 19:41 v.mayatskih at gmail dot com
2017-03-23 19:07 ` [Bug uprobes/21238] " dsmith at redhat dot com
0 siblings, 1 reply; 2+ messages in thread
From: v.mayatskih at gmail dot com @ 2017-03-09 19:41 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=21238
Bug ID: 21238
Summary: Failed user probing does not return proper error
Product: systemtap
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: uprobes
Assignee: systemtap at sourceware dot org
Reporter: v.mayatskih at gmail dot com
Target Milestone: ---
Systemtap 3.1. When uprobe_register fails, systemtap does not print error code:
WARNING: probe process("/usr/lib64/libstdc++.so.6.0.19").function("_Znam")
inode-offset 000000000005f1c0 registration error (rc 0)
WARNING: probe process("/usr/lib64/libstdc++.so.6.0.19").function("_Znwm")
inode-offset 000000000005f0b0 registration error (rc 0)
This fixes it:
--- a/runtime/linux/uprobes-inode.c 2017-02-17 12:37:01.000000000 -0500
+++ b/runtime/linux/uprobes-inode.c 2017-03-09 14:13:28.271403434 -0500
@@ -390,7 +390,8 @@
c->return_p ? "ret" : "",
c->probe->index);
continue;
}
- if (stapiu_register(target->inode, c) != 0)
+ ret = stapiu_register(target->inode, c);
+ if (ret != 0)
_stp_warn("probe %s inode-offset %p
registration error (rc %d)",
c->probe->pp, (void*) (uintptr_t)
c->offset, ret);
}
WARNING: probe process("/usr/lib64/libstdc++.so.6.0.19").function("_Znam")
inode-offset 000000000005f1c0 registration error (rc -5)
WARNING: probe process("/usr/lib64/libstdc++.so.6.0.19").function("_Znwm")
inode-offset 000000000005f0b0 registration error (rc -5)
WARNING: task_finder mmap inode-uprobes callback for task 11766 failed: -5
Looks like a regression.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug uprobes/21238] Failed user probing does not return proper error
2017-03-09 19:41 [Bug uprobes/21238] New: Failed user probing does not return proper error v.mayatskih at gmail dot com
@ 2017-03-23 19:07 ` dsmith at redhat dot com
0 siblings, 0 replies; 2+ messages in thread
From: dsmith at redhat dot com @ 2017-03-23 19:07 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=21238
David Smith <dsmith at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
CC| |dsmith at redhat dot com
Resolution|--- |FIXED
--- Comment #1 from David Smith <dsmith at redhat dot com> ---
Thanks for the patch. Fixed in commit 90871d0.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-23 19:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-09 19:41 [Bug uprobes/21238] New: Failed user probing does not return proper error v.mayatskih at gmail dot com
2017-03-23 19:07 ` [Bug uprobes/21238] " dsmith at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).