[Bug releng/21435] New: convenience groupadd for the make install target

[Bug releng/21435] New: convenience groupadd for the make install target

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21435

            Bug ID: 21435
           Summary: convenience groupadd for the make install target
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: releng
          Assignee: systemtap at sourceware dot org
          Reporter: mcermak at redhat dot com
  Target Milestone: ---

Created attachment 10022
  --> https://sourceware.org/bugzilla/attachment.cgi?id=10022&action=edit
possible patch

When stap gets built and installed from source on a freshly provisioned system,
where the 'stapusr' group doesn't exist, the installation fails:

=======
$ sudo make install

[ ... ]

make[3]: Entering directory '/root/build/stapbpf'
make[4]: Entering directory '/root/build/stapbpf'
 /usr/bin/mkdir -p '/usr/local/bin'
  /usr/bin/install -c stapbpf '/usr/local/bin'
make  install-exec-hook
make[5]: Entering directory '/root/build/stapbpf'
if [ `id -u` -eq 0 ]; then \
        getent group stapusr >/dev/null \
        && chgrp stapusr "/usr/local/bin/stapbpf" \
        && chmod 04110 "/usr/local/bin/stapbpf"; \
fi
Makefile:757: recipe for target 'install-exec-hook' failed
make[5]: *** [install-exec-hook] Error 2
make[5]: Leaving directory '/root/build/stapbpf'
Makefile:692: recipe for target 'install-exec-am' failed
make[4]: *** [install-exec-am] Error 2
make[4]: Leaving directory '/root/build/stapbpf'
Makefile:636: recipe for target 'install-am' failed
make[3]: *** [install-am] Error 2
make[3]: Leaving directory '/root/build/stapbpf'
Makefile:630: recipe for target 'install' failed
make[2]: *** [install] Error 2
make[2]: Leaving directory '/root/build/stapbpf'
Makefile:1966: recipe for target 'install-recursive' failed
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory '/root/build'
Makefile:2207: recipe for target 'install' failed
make: *** [install] Error 2
$
=======

Attached patch mimics the behavior of systemtap.spec, and makes this use case
convenient.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug releng/21435] convenience groupadd for the make install target

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21435

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dsmith at redhat dot com

--- Comment #1 from David Smith <dsmith at redhat dot com> ---
Comment on attachment 10022
  --> https://sourceware.org/bugzilla/attachment.cgi?id=10022
possible patch

Looks fine to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug releng/21435] convenience groupadd for the make install target

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21435

Martin Cermak <mcermak at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Martin Cermak <mcermak at redhat dot com> ---
Ficed in commit 1142af162a0af29566b51e40f92286ce8f867c3c .

-- 
You are receiving this mail because:
You are the assignee for the bug.