* [Bug tapsets/22327] New: the loadavg tapset no longer works on recent kernels
@ 2017-10-20 13:30 dsmith at redhat dot com
2017-10-25 13:18 ` [Bug tapsets/22327] " dsmith at redhat dot com
0 siblings, 1 reply; 2+ messages in thread
From: dsmith at redhat dot com @ 2017-10-20 13:30 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=22327
Bug ID: 22327
Summary: the loadavg tapset no longer works on recent kernels
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: tapsets
Assignee: systemtap at sourceware dot org
Reporter: dsmith at redhat dot com
Target Milestone: ---
The loadavg.stp tapset file causes compile errors when used on newer kernels
(4.14.0-0.rc4.git4.1.fc28.x86_64):
===
# stap -e 'probe begin { printf("%d\n", get_loadavg_index(0)) }'
/tmp/stap1Qjd3Z/stap_6b78fa1883092e0faa7bc608dd2ee82f_1402_src.c: In function
‘function___global_get_loadavg_index__overload_0’:
/tmp/stap1Qjd3Z/stap_6b78fa1883092e0faa7bc608dd2ee82f_1402_src.c:223:10: error:
‘avenrun’ undeclared (first use in this function)
value = avenrun[STAP_ARG_indx] + (FIXED_1/200);
^~~~~~~
/tmp/stap1Qjd3Z/stap_6b78fa1883092e0faa7bc608dd2ee82f_1402_src.c:223:10: note:
each undeclared identifier is reported only once for each function it appears
in
/tmp/stap1Qjd3Z/stap_6b78fa1883092e0faa7bc608dd2ee82f_1402_src.c:223:36: error:
‘FIXED_1’ undeclared (first use in this function)
value = avenrun[STAP_ARG_indx] + (FIXED_1/200);
^~~~~~~
/tmp/stap1Qjd3Z/stap_6b78fa1883092e0faa7bc608dd2ee82f_1402_src.c:35:29: error:
‘FSHIFT’ undeclared (first use in this function); did you mean ‘FS_XFS’?
#define LOAD_INT(x) ((x) >> FSHIFT)
^
/tmp/stap1Qjd3Z/stap_6b78fa1883092e0faa7bc608dd2ee82f_1402_src.c:225:18: note:
in expansion of macro ‘LOAD_INT’
STAP_RETVALUE = LOAD_INT(value);
^~~~~~~~
make[1]: *** [scripts/Makefile.build:313:
/tmp/stap1Qjd3Z/stap_6b78fa1883092e0faa7bc608dd2ee82f_1402_src.o] Error 1
make: *** [Makefile:1502: _module_/tmp/stap1Qjd3Z] Error 2
WARNING: kbuild exited with status: 2
Pass 4: compilation failed. [man error::pass4]
====
This happens because the following kernel commit moved the loadavg related
definitions:
====
commit dea38c74cb9205341f52b8d8ae18f61247a43ea8
Author: Ingo Molnar <mingo@kernel.org>
Date: Wed Feb 1 18:25:37 2017 +0100
sched/headers: Move loadavg related definitions from <linux/sched.h> to
<linux/sched/loadavg.h>
Move these bits to <linux/sched/loadavg.h>, to reduce the size and
complexity of <linux/sched.h>.
====
The tapset will need to adapt.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug tapsets/22327] the loadavg tapset no longer works on recent kernels
2017-10-20 13:30 [Bug tapsets/22327] New: the loadavg tapset no longer works on recent kernels dsmith at redhat dot com
@ 2017-10-25 13:18 ` dsmith at redhat dot com
0 siblings, 0 replies; 2+ messages in thread
From: dsmith at redhat dot com @ 2017-10-25 13:18 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=22327
David Smith <dsmith at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from David Smith <dsmith at redhat dot com> ---
Fixed in commit d31813abd. This commit also adds a buildok test, so we'll
notice any breakage more quickly in the future.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-25 13:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-20 13:30 [Bug tapsets/22327] New: the loadavg tapset no longer works on recent kernels dsmith at redhat dot com
2017-10-25 13:18 ` [Bug tapsets/22327] " dsmith at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).