* [Bug runtime/22551] New: on rawhide, we're getting a compile error that init_timer() doesn't exist
@ 2017-12-05 22:31 dsmith at redhat dot com
2017-12-06 20:38 ` [Bug runtime/22551] " dsmith at redhat dot com
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: dsmith at redhat dot com @ 2017-12-05 22:31 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=22551
Bug ID: 22551
Summary: on rawhide, we're getting a compile error that
init_timer() doesn't exist
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: runtime
Assignee: systemtap at sourceware dot org
Reporter: dsmith at redhat dot com
Target Milestone: ---
On 4.15.0-0.rc1.git3.1.fc28.x86_64, I'm seeing the following:
====
stap -p4 -e 'probe begin { exit() }'
In file included from
/usr/local/share/systemtap/runtime/transport/transport.c:65:0,
from /usr/local/share/systemtap/runtime/linux/print.c:17,
from /usr/local/share/systemtap/runtime/print.c:17,
from /usr/local/share/systemtap/runtime/runtime_context.h:22,
from
/tmp/stapn0pvvU/stap_a64b174160f580702e3079239f11b6ac_1080_src.c:53:
/usr/local/share/systemtap/runtime/transport/relay_v2.c: In function
‘__stp_relay_timer_init’:
/usr/local/share/systemtap/runtime/transport/relay_v2.c:154:2: error: implicit
declaration of function ‘init_timer’; did you mean ‘init_timers’?
[-Werror=implicit-function-declaration]
init_timer(&_stp_relay_data.timer);
^~~~~~~~~~
init_timers
/usr/local/share/systemtap/runtime/transport/relay_v2.c:156:33: error:
assignment from incompatible pointer type [-Werror=incompatible-pointer-types]
_stp_relay_data.timer.function = __stp_relay_wakeup_timer;
^
/usr/local/share/systemtap/runtime/transport/relay_v2.c:157:23: error: ‘struct
timer_list’ has no member named ‘data’
_stp_relay_data.timer.data = 0;
^
In file included from /usr/local/share/systemtap/runtime/linux/print.c:17:0,
from /usr/local/share/systemtap/runtime/print.c:17,
from /usr/local/share/systemtap/runtime/runtime_context.h:22,
from
/tmp/stapn0pvvU/stap_a64b174160f580702e3079239f11b6ac_1080_src.c:53:
/usr/local/share/systemtap/runtime/transport/transport.c: In function
‘_stp_attach’:
/usr/local/share/systemtap/runtime/transport/transport.c:328:31: error:
assignment from incompatible pointer type [-Werror=incompatible-pointer-types]
_stp_ctl_work_timer.function = _stp_ctl_work_callback;
^
/usr/local/share/systemtap/runtime/transport/transport.c:329:21: error: ‘struct
timer_list’ has no member named ‘data’
_stp_ctl_work_timer.data= 0;
^
cc1: all warnings being treated as errors
make[1]: *** [scripts/Makefile.build:310:
/tmp/stapn0pvvU/stap_a64b174160f580702e3079239f11b6ac_1080_src.o] Error 1
make: *** [Makefile:1506: _module_/tmp/stapn0pvvU] Error 2
WARNING: kbuild exited with status: 2
Pass 4: compilation failed. [man error::pass4]
====
The first error, "implicit declaration of function ‘init_timer’" seems to be
caused by the following upstream kernel commit:
====
commit 7eeb6b893bd28c68b6d664de1d3120e49b855cdb
Author: Kees Cook <keescook@chromium.org>
Date: Wed Oct 11 23:13:49 2017 -0700
timer: Remove init_timer() interface
All users of init_timer() have been updated. Remove the ancient interface.
====
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug runtime/22551] on rawhide, we're getting a compile error that init_timer() doesn't exist
2017-12-05 22:31 [Bug runtime/22551] New: on rawhide, we're getting a compile error that init_timer() doesn't exist dsmith at redhat dot com
@ 2017-12-06 20:38 ` dsmith at redhat dot com
2017-12-07 4:47 ` lufq.fnst at cn dot fujitsu.com
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: dsmith at redhat dot com @ 2017-12-06 20:38 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=22551
David Smith <dsmith at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from David Smith <dsmith at redhat dot com> ---
Fixed in commit fbb26e17a.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug runtime/22551] on rawhide, we're getting a compile error that init_timer() doesn't exist
2017-12-05 22:31 [Bug runtime/22551] New: on rawhide, we're getting a compile error that init_timer() doesn't exist dsmith at redhat dot com
2017-12-06 20:38 ` [Bug runtime/22551] " dsmith at redhat dot com
@ 2017-12-07 4:47 ` lufq.fnst at cn dot fujitsu.com
2017-12-07 10:44 ` fche at redhat dot com
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: lufq.fnst at cn dot fujitsu.com @ 2017-12-07 4:47 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=22551
Lu Fengqi <lufq.fnst at cn dot fujitsu.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lufq.fnst at cn dot fujitsu.com
--- Comment #2 from Lu Fengqi <lufq.fnst at cn dot fujitsu.com> ---
(In reply to David Smith from comment #1)
> Fixed in commit fbb26e17a.
Hi, I am new to systemtap.
Of course, your patch is better than mine. However, I have also posted a patch
to fix this case three days ago.
https://sourceware.org/ml/systemtap/2017-q4/msg00164.html
Although I've read HACKING to understand the contribution procedures to
systemtap, I'm still not sure whether it is enough to send the patch to the
mailing list (when I want to contribute to systemtap next time). For example,
do I need to report a bug on Bugzilla first?
If possible could you please tell me about how to contribute to systemtap.
Thanks,
Lu
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug runtime/22551] on rawhide, we're getting a compile error that init_timer() doesn't exist
2017-12-05 22:31 [Bug runtime/22551] New: on rawhide, we're getting a compile error that init_timer() doesn't exist dsmith at redhat dot com
2017-12-06 20:38 ` [Bug runtime/22551] " dsmith at redhat dot com
2017-12-07 4:47 ` lufq.fnst at cn dot fujitsu.com
@ 2017-12-07 10:44 ` fche at redhat dot com
2017-12-07 12:00 ` lufq.fnst at cn dot fujitsu.com
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: fche at redhat dot com @ 2017-12-07 10:44 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=22551
Frank Ch. Eigler <fche at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fche at redhat dot com
--- Comment #3 from Frank Ch. Eigler <fche at redhat dot com> ---
(In reply to Lu Fengqi from comment #2)
> Of course, your patch is better than mine. However, I have also posted a
> patch to fix this case three days ago.
> https://sourceware.org/ml/systemtap/2017-q4/msg00164.html
That is great, sorry that your patch was just accidentally overlooked.
> If possible could you please tell me about how to contribute to systemtap.
You did the right thing. I don't think this overlooking will happen again. To
make it even more unlikely, please consider also opening a bugzilla report
about such problems. That way the chances of "crossed wires" is smaller.
Thanks again!
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug runtime/22551] on rawhide, we're getting a compile error that init_timer() doesn't exist
2017-12-05 22:31 [Bug runtime/22551] New: on rawhide, we're getting a compile error that init_timer() doesn't exist dsmith at redhat dot com
` (2 preceding siblings ...)
2017-12-07 10:44 ` fche at redhat dot com
@ 2017-12-07 12:00 ` lufq.fnst at cn dot fujitsu.com
2017-12-07 16:01 ` dsmith at redhat dot com
2017-12-08 1:32 ` lufq.fnst at cn dot fujitsu.com
5 siblings, 0 replies; 7+ messages in thread
From: lufq.fnst at cn dot fujitsu.com @ 2017-12-07 12:00 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=22551
--- Comment #4 from Lu Fengqi <lufq.fnst at cn dot fujitsu.com> ---
(In reply to Frank Ch. Eigler from comment #3)
> (In reply to Lu Fengqi from comment #2)
> > Of course, your patch is better than mine. However, I have also posted a
> > patch to fix this case three days ago.
> > https://sourceware.org/ml/systemtap/2017-q4/msg00164.html
>
> That is great, sorry that your patch was just accidentally overlooked.
>
It does not matter, I know how to do it later more importantly.
>
> > If possible could you please tell me about how to contribute to systemtap.
>
> You did the right thing. I don't think this overlooking will happen again.
> To make it even more unlikely, please consider also opening a bugzilla
> report about such problems. That way the chances of "crossed wires" is
> smaller.
>
> Thanks again!
Thank you for taking the time to reply me.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug runtime/22551] on rawhide, we're getting a compile error that init_timer() doesn't exist
2017-12-05 22:31 [Bug runtime/22551] New: on rawhide, we're getting a compile error that init_timer() doesn't exist dsmith at redhat dot com
` (3 preceding siblings ...)
2017-12-07 12:00 ` lufq.fnst at cn dot fujitsu.com
@ 2017-12-07 16:01 ` dsmith at redhat dot com
2017-12-08 1:32 ` lufq.fnst at cn dot fujitsu.com
5 siblings, 0 replies; 7+ messages in thread
From: dsmith at redhat dot com @ 2017-12-07 16:01 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=22551
--- Comment #5 from David Smith <dsmith at redhat dot com> ---
(In reply to Lu Fengqi from comment #2)
> (In reply to David Smith from comment #1)
> > Fixed in commit fbb26e17a.
>
> Hi, I am new to systemtap.
>
> Of course, your patch is better than mine. However, I have also posted a
> patch to fix this case three days ago.
>
> https://sourceware.org/ml/systemtap/2017-q4/msg00164.html
I'm so sorry about that. I've been out, and in the crush to catch up I missed
your patch. Thanks so much for trying to help out.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug runtime/22551] on rawhide, we're getting a compile error that init_timer() doesn't exist
2017-12-05 22:31 [Bug runtime/22551] New: on rawhide, we're getting a compile error that init_timer() doesn't exist dsmith at redhat dot com
` (4 preceding siblings ...)
2017-12-07 16:01 ` dsmith at redhat dot com
@ 2017-12-08 1:32 ` lufq.fnst at cn dot fujitsu.com
5 siblings, 0 replies; 7+ messages in thread
From: lufq.fnst at cn dot fujitsu.com @ 2017-12-08 1:32 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=22551
--- Comment #6 from Lu Fengqi <lufq.fnst at cn dot fujitsu.com> ---
(In reply to David Smith from comment #5)
> (In reply to Lu Fengqi from comment #2)
> > (In reply to David Smith from comment #1)
> > > Fixed in commit fbb26e17a.
> >
> > Hi, I am new to systemtap.
> >
> > Of course, your patch is better than mine. However, I have also posted a
> > patch to fix this case three days ago.
> >
> > https://sourceware.org/ml/systemtap/2017-q4/msg00164.html
>
> I'm so sorry about that. I've been out, and in the crush to catch up I
> missed your patch. Thanks so much for trying to help out.
It doesn't matter. Thank you for your contribution to systemtap. It is very
helpful for my job.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-12-08 1:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-05 22:31 [Bug runtime/22551] New: on rawhide, we're getting a compile error that init_timer() doesn't exist dsmith at redhat dot com
2017-12-06 20:38 ` [Bug runtime/22551] " dsmith at redhat dot com
2017-12-07 4:47 ` lufq.fnst at cn dot fujitsu.com
2017-12-07 10:44 ` fche at redhat dot com
2017-12-07 12:00 ` lufq.fnst at cn dot fujitsu.com
2017-12-07 16:01 ` dsmith at redhat dot com
2017-12-08 1:32 ` lufq.fnst at cn dot fujitsu.com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).