public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* [Bug runtime/23284] New: dmesg should identify the name of the stap script
@ 2018-06-13 15:54 serhei.public at gmail dot com
  2018-06-13 15:56 ` [Bug runtime/23284] " serhei.public at gmail dot com
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: serhei.public at gmail dot com @ 2018-06-13 15:54 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=23284

            Bug ID: 23284
           Summary: dmesg should identify the name of the stap script
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: serhei.public at gmail dot com
  Target Milestone: ---

Many systemtap issues can be diagnosed by viewing dmesg output during a
testsuite run. Dmesg prints the module name when a stap module is loaded.
However, neither systemtap.sum nor systemtap.log record the stap module name
for every stap run, so it's not easy to tell which testcase caused a particular
warning.

This can be fixed by having the runtime print the original name of the script
file to dmesg.

The eBPF backend should also do this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug runtime/23284] dmesg should identify the name of the stap script
  2018-06-13 15:54 [Bug runtime/23284] New: dmesg should identify the name of the stap script serhei.public at gmail dot com
@ 2018-06-13 15:56 ` serhei.public at gmail dot com
  2018-07-03 12:45 ` mcermak at redhat dot com
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: serhei.public at gmail dot com @ 2018-06-13 15:56 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=23284

--- Comment #1 from Serhei Makarov <serhei.public at gmail dot com> ---
I've implemented a basic patch for this.

However, typically the full path to the stap script file is printed. It would
probably be good to trim directories from the stap file path.

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug runtime/23284] dmesg should identify the name of the stap script
  2018-06-13 15:54 [Bug runtime/23284] New: dmesg should identify the name of the stap script serhei.public at gmail dot com
  2018-06-13 15:56 ` [Bug runtime/23284] " serhei.public at gmail dot com
@ 2018-07-03 12:45 ` mcermak at redhat dot com
  2018-07-03 18:52 ` serhei.public at gmail dot com
  2018-07-05 15:49 ` serhei.public at gmail dot com
  3 siblings, 0 replies; 5+ messages in thread
From: mcermak at redhat dot com @ 2018-07-03 12:45 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=23284

Martin Cermak <mcermak at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcermak at redhat dot com

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug runtime/23284] dmesg should identify the name of the stap script
  2018-06-13 15:54 [Bug runtime/23284] New: dmesg should identify the name of the stap script serhei.public at gmail dot com
  2018-06-13 15:56 ` [Bug runtime/23284] " serhei.public at gmail dot com
  2018-07-03 12:45 ` mcermak at redhat dot com
@ 2018-07-03 18:52 ` serhei.public at gmail dot com
  2018-07-05 15:49 ` serhei.public at gmail dot com
  3 siblings, 0 replies; 5+ messages in thread
From: serhei.public at gmail dot com @ 2018-07-03 18:52 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=23284

--- Comment #2 from Serhei Makarov <serhei.public at gmail dot com> ---
Directory trimming implemented in commit 55b338a5.

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug runtime/23284] dmesg should identify the name of the stap script
  2018-06-13 15:54 [Bug runtime/23284] New: dmesg should identify the name of the stap script serhei.public at gmail dot com
                   ` (2 preceding siblings ...)
  2018-07-03 18:52 ` serhei.public at gmail dot com
@ 2018-07-05 15:49 ` serhei.public at gmail dot com
  3 siblings, 0 replies; 5+ messages in thread
From: serhei.public at gmail dot com @ 2018-07-05 15:49 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=23284

Serhei Makarov <serhei.public at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Serhei Makarov <serhei.public at gmail dot com> ---
Equivalent functionality for stapbpf implemented in commit c38895a2a7. For
every bpf program loaded into the kernel, stapbpf outputs a corresponding
notice to dmesg(), mirroring _stp_print_kernel_info in the default backend.

This required defining a new ELF section 'stapbpf_script_name' in the .bo files
output by bpf-translate.cxx.

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-07-05 15:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-13 15:54 [Bug runtime/23284] New: dmesg should identify the name of the stap script serhei.public at gmail dot com
2018-06-13 15:56 ` [Bug runtime/23284] " serhei.public at gmail dot com
2018-07-03 12:45 ` mcermak at redhat dot com
2018-07-03 18:52 ` serhei.public at gmail dot com
2018-07-05 15:49 ` serhei.public at gmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).