public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* [Bug bpf/24543] New: stapbpf breaks when cpu0 is disabled
@ 2019-05-09 18:52 me at serhei dot io
  2019-06-24 18:29 ` [Bug bpf/24543] " me at serhei dot io
  0 siblings, 1 reply; 2+ messages in thread
From: me at serhei dot io @ 2019-05-09 18:52 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=24543

            Bug ID: 24543
           Summary: stapbpf breaks when cpu0 is disabled
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: bpf
          Assignee: systemtap at sourceware dot org
          Reporter: me at serhei dot io
  Target Milestone: ---

There is code in stapbpf to handle the case when some cpu cores are disabled.

However, certain things in stapbpf.cxx are still hardcoded to cpu0 (e.g. perf
group fd). If cpu0 is disabled, stapbpf doesn't work.

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug bpf/24543] stapbpf breaks when cpu0 is disabled
  2019-05-09 18:52 [Bug bpf/24543] New: stapbpf breaks when cpu0 is disabled me at serhei dot io
@ 2019-06-24 18:29 ` me at serhei dot io
  0 siblings, 0 replies; 2+ messages in thread
From: me at serhei dot io @ 2019-06-24 18:29 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=24543

Serhei Makarov <me at serhei dot io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Serhei Makarov <me at serhei dot io> ---
Strictly speaking cpu0 is not always safe or possible to disable. But I was
able to do so on a test vm, so the fix has been committed just in case. (As
usual, before the fix stapbpf's error message is based on a failing syscall
return code, which fails to reveal the reason why things don't work.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-24 18:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-09 18:52 [Bug bpf/24543] New: stapbpf breaks when cpu0 is disabled me at serhei dot io
2019-06-24 18:29 ` [Bug bpf/24543] " me at serhei dot io

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).