public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "me at serhei dot io" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug bpf/24759] New: stapbpf-next housekeeping: need version checking between stap translator and stapbpf
Date: Tue, 02 Jul 2019 18:27:00 -0000	[thread overview]
Message-ID: <bug-24759-6586@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=24759

            Bug ID: 24759
           Summary: stapbpf-next housekeeping: need version checking
                    between stap translator and stapbpf
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: bpf
          Assignee: systemtap at sourceware dot org
          Reporter: me at serhei dot io
  Target Milestone: ---

Currently you can generate a .bo module with one version of the systemtap
translator and feed it to a different version of stapbpf, which will dutifully
try to interpret it.

Because a lot of stapbpf feature work requires tweaks to the ELF format
(changing the ABI of stapbpf modules), this can result in nonsense behaviour.
For example, pr23858 work will require changing the ABI of the
bpf_map_get_next_key helper.

We should write the stap version in a new section of the .bo file and have
stapbpf check it. By default, stapbpf should output an error (or warning) if
the versions do not match.

In future, we can look at what's required to safely enable compatibility
between different stap translator and stapbpf versions. For example, we may
want a newer translator (deployed locally, easy to update) to be able to
generate code for an older (deployed elsewhere, hard to update) stapbpf
version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

             reply	other threads:[~2019-07-02 18:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02 18:27 me at serhei dot io [this message]
2019-07-02 18:47 ` [Bug bpf/24759] " me at serhei dot io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-24759-6586@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).