public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "craig.ringer at 2ndquadrant dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug tapsets/25686] New: user_buffer_quoted incorrectly octal-escapes non-printable characters
Date: Tue, 17 Mar 2020 14:12:46 +0000	[thread overview]
Message-ID: <bug-25686-6586@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=25686

            Bug ID: 25686
           Summary: user_buffer_quoted incorrectly octal-escapes
                    non-printable characters
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: tapsets
          Assignee: systemtap at sourceware dot org
          Reporter: craig.ringer at 2ndquadrant dot com
  Target Milestone: ---

`user_buffer_quoted` omits leading zeroes from octal escapes even when the next
character is a printable digit. This leads to incorrectly escaped data.

E.g. given the buffer `1\x006\x00` i.e. hex-representation `31 00 36 00`,
`user_buffer_quoted` will emit `1\06\0`. This will decode to hex-bytes `31 06
00` because the sequence `\06` is interpreted as "octal 06" not "octal 0, then
ascii printable digit 6".

The underlying bug appears to be in `_stp_text_str`.

-- 
You are receiving this mail because:
You are the assignee for the bug.

             reply	other threads:[~2020-03-17 14:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-17 14:12 craig.ringer at 2ndquadrant dot com [this message]
2020-03-17 14:27 ` [Bug tapsets/25686] " craig.ringer at 2ndquadrant dot com
2020-03-17 14:27 ` craig.ringer at 2ndquadrant dot com
2020-03-17 14:28 ` craig.ringer at 2ndquadrant dot com
2020-03-29 20:44 ` fche at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25686-6586@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).