public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "wcohen at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug tapsets/26152] _struct_compat_timex_u() function doesn't work on rhel8
Date: Mon, 29 Jun 2020 15:39:32 +0000	[thread overview]
Message-ID: <bug-26152-6586-nzfhl3xhDu@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-26152-6586@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=26152

--- Comment #1 from William Cohen <wcohen at redhat dot com> ---
git bisect showed that the problem occurs due to:


commit 4ab42baafca69953229422923ec0721abebb570f
Author: Frank Ch. Eigler <fche@redhat.com>
Date:   Wed Dec 11 15:28:46 2019 -0500

    tapset: _struct_compat_timex_u() support after renaming to old_timex32

    Kernel commit 4d5f007eedb74d (v5.1+) renames the old compat_timex
    structure to old_timex32.


The CONFIG_COMPAT_32BIT_TIME was added to kernels before struct old_timex32.
CONFIG_COMPAT_32BIT_TIME available in 4.18 kenels, but old_timex32 wasn't added
to kernels until:

Author: Arnd Bergmann <arnd@arndb.de>  2019-01-02 07:28:47
Committer: Arnd Bergmann <arnd@arndb.de>  2019-02-06 18:13:27
Parent: 805089c2f77047d81f47ddc227435d606ceb180e (syscalls: remove obsolete
__IGNORE_ macros)
Child:  2c620ff93d9fbd5d644760d4c21d389078ec1080 (time: Add struct
__kernel_timex)
Branches: master, remotes/origin/master, wcohen/gcc9
Follows: v5.0-rc2
Precedes: v5.1-rc1

    time: make adjtime compat handling available for 32 bit

    We want to reuse the compat_timex handling on 32-bit architectures the
    same way we are using the compat handling for timespec when moving to
    64-bit time_t.

    Move all definitions related to compat_timex out of the compat code
    into the normal timekeeping code, along with a rename to old_timex32,
    corresponding to the timespec/timeval structures, and make it controlled
    by CONFIG_COMPAT_32BIT_TIME, which 32-bit architectures will then select.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

-- 
You are receiving this mail because:
You are the assignee for the bug.

  reply	other threads:[~2020-06-29 15:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-22 18:45 [Bug tapsets/26152] New: " wcohen at redhat dot com
2020-06-29 15:39 ` wcohen at redhat dot com [this message]
2023-10-04 14:30 ` [Bug tapsets/26152] " wcohen at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-26152-6586-nzfhl3xhDu@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).