* [Bug tapsets/26249] New: [PATCH] uconversions format error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘void *’ [-Werror=format=]
@ 2020-07-16 10:23 craig.ringer at 2ndquadrant dot com
2020-07-16 11:11 ` [Bug tapsets/26249] " craig.ringer at 2ndquadrant dot com
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: craig.ringer at 2ndquadrant dot com @ 2020-07-16 10:23 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=26249
Bug ID: 26249
Summary: [PATCH] uconversions format error: format ‘%lx’
expects argument of type ‘long unsigned int’, but
argument 5 has type ‘void *’ [-Werror=format=]
Product: systemtap
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: tapsets
Assignee: systemtap at sourceware dot org
Reporter: craig.ringer at 2ndquadrant dot com
Target Milestone: ---
Please apply the following fix:
sed -i 's/user string copy fault at 0x%lx/user string copy fault at 0x%p/g'
tapset/uconversions.stp
to prevent this error on gcc 10.1.1 (Fedora 32):
/tmp/stapZ1uHM9/stap_35d624015b7561890f7e266d60669c82_7434_src.c: In function
‘function___global_user_string_n_warn__overload_1’:
/tmp/stapZ1uHM9/stap_35d624015b7561890f7e266d60669c82_7434_src.c:1139:40:
error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument
5 has type ‘void *’ [-Werror=format=]
1139 | "user string copy fault 0x%ld at %lx [man error::fault]", rc,
| ~~^
| |
| long unsigned int
| %p
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tapsets/26249] [PATCH] uconversions format error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘void *’ [-Werror=format=]
2020-07-16 10:23 [Bug tapsets/26249] New: [PATCH] uconversions format error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘void *’ [-Werror=format=] craig.ringer at 2ndquadrant dot com
@ 2020-07-16 11:11 ` craig.ringer at 2ndquadrant dot com
2020-07-16 18:26 ` fche at redhat dot com
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: craig.ringer at 2ndquadrant dot com @ 2020-07-16 11:11 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=26249
--- Comment #1 from Craig Ringer <craig.ringer at 2ndquadrant dot com> ---
This one too
user string copy fault 0x%ld at %lx
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tapsets/26249] [PATCH] uconversions format error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘void *’ [-Werror=format=]
2020-07-16 10:23 [Bug tapsets/26249] New: [PATCH] uconversions format error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘void *’ [-Werror=format=] craig.ringer at 2ndquadrant dot com
2020-07-16 11:11 ` [Bug tapsets/26249] " craig.ringer at 2ndquadrant dot com
@ 2020-07-16 18:26 ` fche at redhat dot com
2020-07-17 2:30 ` craig.ringer at 2ndquadrant dot com
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: fche at redhat dot com @ 2020-07-16 18:26 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=26249
Frank Ch. Eigler <fche at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fche at redhat dot com
--- Comment #2 from Frank Ch. Eigler <fche at redhat dot com> ---
Good catch, but I'd rather have the code switch to %lx and (unsigned long)
casts, rather than %p (which is sometimes censored).
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tapsets/26249] [PATCH] uconversions format error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘void *’ [-Werror=format=]
2020-07-16 10:23 [Bug tapsets/26249] New: [PATCH] uconversions format error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘void *’ [-Werror=format=] craig.ringer at 2ndquadrant dot com
2020-07-16 11:11 ` [Bug tapsets/26249] " craig.ringer at 2ndquadrant dot com
2020-07-16 18:26 ` fche at redhat dot com
@ 2020-07-17 2:30 ` craig.ringer at 2ndquadrant dot com
2020-07-20 1:41 ` craig.ringer at 2ndquadrant dot com
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: craig.ringer at 2ndquadrant dot com @ 2020-07-17 2:30 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=26249
--- Comment #3 from Craig Ringer <craig.ringer at 2ndquadrant dot com> ---
OK, good to know. I'll prep a patch.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tapsets/26249] [PATCH] uconversions format error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘void *’ [-Werror=format=]
2020-07-16 10:23 [Bug tapsets/26249] New: [PATCH] uconversions format error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘void *’ [-Werror=format=] craig.ringer at 2ndquadrant dot com
` (2 preceding siblings ...)
2020-07-17 2:30 ` craig.ringer at 2ndquadrant dot com
@ 2020-07-20 1:41 ` craig.ringer at 2ndquadrant dot com
2020-07-20 1:42 ` craig.ringer at 2ndquadrant dot com
2020-07-29 0:30 ` fche at redhat dot com
5 siblings, 0 replies; 7+ messages in thread
From: craig.ringer at 2ndquadrant dot com @ 2020-07-20 1:41 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=26249
Craig Ringer <craig.ringer at 2ndquadrant dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |craig.ringer at 2ndquadrant dot co
| |m
--- Comment #4 from Craig Ringer <craig.ringer at 2ndquadrant dot com> ---
Created attachment 12711
--> https://sourceware.org/bugzilla/attachment.cgi?id=12711&action=edit
Switch uconversions.stp from %p to %lx
Patch attached as suggested.
I switched all the %p and %lx formats to a consistent form.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tapsets/26249] [PATCH] uconversions format error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘void *’ [-Werror=format=]
2020-07-16 10:23 [Bug tapsets/26249] New: [PATCH] uconversions format error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘void *’ [-Werror=format=] craig.ringer at 2ndquadrant dot com
` (3 preceding siblings ...)
2020-07-20 1:41 ` craig.ringer at 2ndquadrant dot com
@ 2020-07-20 1:42 ` craig.ringer at 2ndquadrant dot com
2020-07-29 0:30 ` fche at redhat dot com
5 siblings, 0 replies; 7+ messages in thread
From: craig.ringer at 2ndquadrant dot com @ 2020-07-20 1:42 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=26249
--- Comment #5 from Craig Ringer <craig.ringer at 2ndquadrant dot com> ---
Created attachment 12712
--> https://sourceware.org/bugzilla/attachment.cgi?id=12712&action=edit
Same for linux/conversions.stp
Also attached a similar change for linux/conversions.stp
I didn't run patch 0002 through the tests, so it's just here in case it's
useful. Patch 0001 is sufficient to fix the reported bug.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tapsets/26249] [PATCH] uconversions format error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘void *’ [-Werror=format=]
2020-07-16 10:23 [Bug tapsets/26249] New: [PATCH] uconversions format error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘void *’ [-Werror=format=] craig.ringer at 2ndquadrant dot com
` (4 preceding siblings ...)
2020-07-20 1:42 ` craig.ringer at 2ndquadrant dot com
@ 2020-07-29 0:30 ` fche at redhat dot com
5 siblings, 0 replies; 7+ messages in thread
From: fche at redhat dot com @ 2020-07-29 0:30 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=26249
Frank Ch. Eigler <fche at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
--- Comment #6 from Frank Ch. Eigler <fche at redhat dot com> ---
merged, thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-07-29 0:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-16 10:23 [Bug tapsets/26249] New: [PATCH] uconversions format error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘void *’ [-Werror=format=] craig.ringer at 2ndquadrant dot com
2020-07-16 11:11 ` [Bug tapsets/26249] " craig.ringer at 2ndquadrant dot com
2020-07-16 18:26 ` fche at redhat dot com
2020-07-17 2:30 ` craig.ringer at 2ndquadrant dot com
2020-07-20 1:41 ` craig.ringer at 2ndquadrant dot com
2020-07-20 1:42 ` craig.ringer at 2ndquadrant dot com
2020-07-29 0:30 ` fche at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).