[Bug tapsets/26254] New: [PATCH] Syntax error in sssd_functions.stp at METHOD_SENTINEL

[Bug tapsets/26254] New: [PATCH] Syntax error in sssd_functions.stp at METHOD_SENTINEL

[craig.ringer at 2ndquadrant dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26254

            Bug ID: 26254
           Summary: [PATCH] Syntax error in sssd_functions.stp at
                    METHOD_SENTINEL
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: tapsets
          Assignee: systemtap at sourceware dot org
          Reporter: craig.ringer at 2ndquadrant dot com
  Target Milestone: ---

I see the following complaint on even trivial probes on Fedora 32:


parse error: expected 'probe', 'global', 'private', 'function', or '%{'
        saw: identifier 'METHOD_SENTINEL' at
/usr/share/systemtap/tapset/sssd_functions.stp:10:34
     source:        METHOD_RESOLVER_HANDLER=9 METHOD_SENTINEL=10
                                              ^

This turns out to be in an externally supplied tapset:

$ rpm -qf /usr/share/systemtap/tapset/sssd_functions.stp
sssd-common-2.3.0-1.fc32.x86_64

but I'm opening an issue here to make the problem searchable, since I had
started a bug before I realised it wasn't part of systemtap itself. It's fixed
in upstream sssd by
https://github.com/SSSD/sssd/blob/master/src/systemtap/sssd_functions.stp .

The cause is a missing comma.

My versions:

$ rpm -q --qf '%{name}-%{version}-%{release}\n' gcc gcc
fedora-release-workstation 
gcc-10.1.1-1.fc32
gcc-10.1.1-1.fc32
fedora-release-workstation-32-3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug tapsets/26254] [PATCH] Syntax error in sssd_functions.stp at METHOD_SENTINEL

[craig.ringer at 2ndquadrant dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26254

Craig Ringer <craig.ringer at 2ndquadrant dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                URL|                            |https://github.com/SSSD/sss
                   |                            |d/commit/66029529fa0f0e2d16
                   |                            |999f22294822deeec5f60b
         Resolution|---                         |INVALID

--- Comment #1 from Craig Ringer <craig.ringer at 2ndquadrant dot com> ---
Fixed by sssd commit
https://github.com/SSSD/sssd/commit/66029529fa0f0e2d16999f22294822deeec5f60b

Apply that patch if you hit this error.

Proposal: in systemtap errors, identify built-in tapsets vs externally provided
tapsets. Perhaps a pragma or similar that allows tapsets to be labeled with
their originating package? It might be obvious that this is part of sssd, but
only if you know what sssd is, and that it's installed...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug tapsets/26254] [PATCH] Syntax error in sssd_functions.stp at METHOD_SENTINEL

[wcohen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26254

William Cohen <wcohen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wcohen at redhat dot com

--- Comment #2 from William Cohen <wcohen at redhat dot com> ---
There was also a fedora bug filed to track this getting fixed in Fedora:

https://bugzilla.redhat.com/show_bug.cgi?id=1840194

-- 
You are receiving this mail because:
You are the assignee for the bug.