public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "scox at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug testsuite/27791] New: hw_breakpoint.exp fails to build
Date: Thu, 29 Apr 2021 14:52:56 +0000	[thread overview]
Message-ID: <bug-27791-6586@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=27791

            Bug ID: 27791
           Summary: hw_breakpoint.exp fails to build
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: systemtap at sourceware dot org
          Reporter: scox at redhat dot com
  Target Milestone: ---

Running /home/scox/systemtap/src/testsuite/systemtap.base/hw_breakpoint.exp ...
make[3]: Entering directory '/tmp/staptestyIP3jy'
make -C /lib/modules/5.12.0-0.rc8.193.el9.x86_64/build
SUBDIRS=/tmp/staptestyIP3jy KBUILD_EXTMOD=/tmp/staptestyIP3jy modules
make[4]: Entering directory '/usr/src/kernels/5.12.0-0.rc8.193.el9.x86_64'
  CC [M]  /tmp/staptestyIP3jy/stap_hwbkpt_kmod.o
make[4]: Leaving directory '/usr/src/kernels/5.12.0-0.rc8.193.el9.x86_64'
make[3]: Leaving directory '/tmp/staptestyIP3jy'
/tmp/staptestyIP3jy/stap_hwbkpt_kmod.c: In function 'init_module':
/tmp/staptestyIP3jy/stap_hwbkpt_kmod.c:82:54: error: passing argument 4 of
'proc_create' from incompatible pointer type
[-Werror=incompatible-pointer-types]|         stm_ctl = proc_create (CMD_FILE,
0666, NULL, &stm_fops_cmd);
      |                                                      ^~~~~~~~~~~~~
      |                                                      |
      |                                                      struct
file_operations *
In file included from /tmp/staptestyIP3jy/stap_hwbkpt_kmod.c:13:
./include/linux/proc_fs.h:109:122: note: expected 'const struct proc_ops *' but
argument is of type 'struct file_operations *'
  109 | struct proc_dir_entry *proc_create(const char *name, umode_t mode,
struct proc_dir_entry *parent, const struct proc_ops *proc_ops);
      |                                                                        
                          ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
cc1: some warnings being treated as errors
make[5]: *** [scripts/Makefile.build:271:
/tmp/staptestyIP3jy/stap_hwbkpt_kmod.o] Error 1
make[4]: *** [Makefile:1862: /tmp/staptestyIP3jy] Error 2
make[3]: *** [Makefile:5: default] Error 2
BUILD FAILED

It needs a bit of porting and/or systemtap runtime autoconfing (which it's not
really setup uto do)
testsuite/systemtap.base/stap_hwbkpt_kmod.c
A stap module should provide this service to the other test case rather than
hand-written c module.  See also STAPCONF_PROC_OPS over in
runtime/transport/procfs.c

-- 
You are receiving this mail because:
You are the assignee for the bug.

             reply	other threads:[~2021-04-29 14:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29 14:52 scox at redhat dot com [this message]
2021-09-23 13:04 ` [Bug testsuite/27791] " dichen at redhat dot com
2022-05-26 17:42 ` scox at redhat dot com
2023-10-03 19:48 ` wcohen at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27791-6586@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).