[Bug testsuite/27791] New: hw_breakpoint.exp fails to build

[Bug testsuite/27791] New: hw_breakpoint.exp fails to build

[scox at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27791

            Bug ID: 27791
           Summary: hw_breakpoint.exp fails to build
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: systemtap at sourceware dot org
          Reporter: scox at redhat dot com
  Target Milestone: ---

Running /home/scox/systemtap/src/testsuite/systemtap.base/hw_breakpoint.exp ...
make[3]: Entering directory '/tmp/staptestyIP3jy'
make -C /lib/modules/5.12.0-0.rc8.193.el9.x86_64/build
SUBDIRS=/tmp/staptestyIP3jy KBUILD_EXTMOD=/tmp/staptestyIP3jy modules
make[4]: Entering directory '/usr/src/kernels/5.12.0-0.rc8.193.el9.x86_64'
  CC [M]  /tmp/staptestyIP3jy/stap_hwbkpt_kmod.o
make[4]: Leaving directory '/usr/src/kernels/5.12.0-0.rc8.193.el9.x86_64'
make[3]: Leaving directory '/tmp/staptestyIP3jy'
/tmp/staptestyIP3jy/stap_hwbkpt_kmod.c: In function 'init_module':
/tmp/staptestyIP3jy/stap_hwbkpt_kmod.c:82:54: error: passing argument 4 of
'proc_create' from incompatible pointer type
[-Werror=incompatible-pointer-types]|         stm_ctl = proc_create (CMD_FILE,
0666, NULL, &stm_fops_cmd);
      |                                                      ^~~~~~~~~~~~~
      |                                                      |
      |                                                      struct
file_operations *
In file included from /tmp/staptestyIP3jy/stap_hwbkpt_kmod.c:13:
./include/linux/proc_fs.h:109:122: note: expected 'const struct proc_ops *' but
argument is of type 'struct file_operations *'
  109 | struct proc_dir_entry *proc_create(const char *name, umode_t mode,
struct proc_dir_entry *parent, const struct proc_ops *proc_ops);
      |                                                                        
                          ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
cc1: some warnings being treated as errors
make[5]: *** [scripts/Makefile.build:271:
/tmp/staptestyIP3jy/stap_hwbkpt_kmod.o] Error 1
make[4]: *** [Makefile:1862: /tmp/staptestyIP3jy] Error 2
make[3]: *** [Makefile:5: default] Error 2
BUILD FAILED

It needs a bit of porting and/or systemtap runtime autoconfing (which it's not
really setup uto do)
testsuite/systemtap.base/stap_hwbkpt_kmod.c
A stap module should provide this service to the other test case rather than
hand-written c module.  See also STAPCONF_PROC_OPS over in
runtime/transport/procfs.c

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug testsuite/27791] hw_breakpoint.exp fails to build

[dichen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27791

Di Chen <dichen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dichen at redhat dot com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug testsuite/27791] hw_breakpoint.exp fails to build

[scox at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27791

--- Comment #1 from Stan Cox <scox at redhat dot com> ---
Committed a partial solution (it still uses a hand written module) that gets
the test working on Linux 5.7.0.  
commit d39c7c68

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug testsuite/27791] hw_breakpoint.exp fails to build

[wcohen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27791

William Cohen <wcohen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wcohen at redhat dot com
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from William Cohen <wcohen at redhat dot com> ---
With the current git checkout of systemtap (commit ca71442b9) see this working
on Fedora rawhide:

Test run by root on Tue Oct  3 15:46:59 2023
Native configuration is x86_64-pc-linux-gnu

                === systemtap tests ===

Schedule of variations:
    unix

Running target unix

Host: Linux rawhide 6.6.0-0.rc3.20230929git9ed22ae6be81.30.fc40.x86_64 #1 SMP
PR
EEMPT_DYNAMIC Fri Sep 29 16:20:55 UTC 2023 x86_64 GNU/Linux
Snapshot: version 5.0/0.189, release-4.8-147-gca71442b
GCC: 13.2.1 [gcc (GCC) 13.2.1 20230918 (Red Hat 13.2.1-3)]
Distro: Fedora release 40 (Rawhide)
SElinux: Enforcing
CPUFlags: flags         : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge
m
ca cmov pat pse36 clflush mmx fxsr sse sse2 ss syscall nx pdpe1gb rdtscp lm
cons
tant_tsc arch_perfmon rep_good nopl xtopology cpuid tsc_known_freq pni
pclmulqdq
 vmx ssse3 fma cx16 pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt
tsc_deadline_tim
er aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch cpuid_fault
ss
bd ibrs ibpb stibp ibrs_enhanced tpr_shadow flexpriority ept vpid ept_ad
fsgsbas
e tsc_adjust sgx bmi1 avx2 smep bmi2 erms invpcid mpx rdseed adx smap
clflushopt
 xsaveopt xsavec xgetbv1 xsaves arat vnmi umip sgx_lc md_clear
arch_capabilities
vmx flags       : vnmi preemption_timer invvpid ept_x_only ept_ad ept_1gb
flexpr
iority tsc_offset vtpr mtf vapic ept vpid unrestricted_guest shadow_vmcs pml
Lockdown: [none] integrity confidentiality


Running
/home/wcohen/systemtap_write/systemtap/testsuite/systemtap.base/hw_break
point.exp ...
PASS: hw_breakpoint (built and installed module)
PASS: hw_breakpoint (found symbol address)
PASS: hw_breakpoint (found cmd file - /proc/stap_hwbkpt_cmd)
PASS: hw_breakpoint - addr (hw breakpoint support)
PASS: hw_breakpoint - symbol (hw breakpoint support)

                === systemtap Summary ===

# of expected passes            5
/home/wcohen/systemtap_write/install/bin/stap version 5.0/0.189,
release-4.8-147
-gca71442b

-- 
You are receiving this mail because:
You are the assignee for the bug.