[Bug translator/27940] New: The /* pc=0x... */ is no longer printed by "stap -v -L 'kernel.function("*")'

[Bug translator/27940] New: The /* pc=0x... */ is no longer printed by "stap -v -L 'kernel.function("*")'

[wcohen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27940

            Bug ID: 27940
           Summary: The /* pc=0x... */ is no longer printed by "stap -v -L
                    'kernel.function("*")'
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
          Assignee: systemtap at sourceware dot org
          Reporter: wcohen at redhat dot com
  Target Milestone: ---

When using a current checkout of systemtap from the git repository I found that
the following no longer included the pc address of the probe point:

$ ../install/bin/stap -v -L 'kernel.function("BTRFS_I")'
Pass 1: parsed user script and 792 library scripts using
3480940virt/3246072res/12984shr/3233236data kb, in 7720usr/700sys/8499real ms.
kernel.function("BTRFS_I@fs/btrfs/btrfs_inode.h:231")
kernel.function("BTRFS_I@fs/btrfs/btrfs_inode.h:231")
kernel.function("BTRFS_I@fs/btrfs/btrfs_inode.h:231")
kernel.function("BTRFS_I@fs/btrfs/btrfs_inode.h:231")


With the recently released systemtap-4.5 on fedora 34 see:

$ stap -v -L 'kernel.function("BTRFS_I")'
Pass 1: parsed user script and 791 library scripts using
3479644virt/3245148res/12412shr/3232604data kb, in 7840usr/660sys/8549real ms.
kernel.function("BTRFS_I@fs/btrfs/btrfs_inode.h:231") /* pc=_stext+0x53a068 */
kernel.function("BTRFS_I@fs/btrfs/btrfs_inode.h:231") /* pc=_stext+0x539ff8 */
kernel.function("BTRFS_I@fs/btrfs/btrfs_inode.h:231") /* pc=_stext+0x539f83 */
kernel.function("BTRFS_I@fs/btrfs/btrfs_inode.h:231") /* pc=_stext+0x5373d3 */
...

Did a binary bisect and tracked the problem down to git commit
545535f8238fe2493dd7b2d415dfa12174284581:

Author: Timm Bäder <tbaeder@redhat.com>  2021-05-19 16:38:30
Committer: Aaron Merey <amerey@redhat.com>  2021-05-19 16:38:30
Parent: 0f4bd3219711e8918eac77c77a1de521832d3dbe (set2: Return this from
assignment operator)
Child:  b3a3929751695310b93ff35f41e68775804cee00 (Fix -Wformat-nonliteral and
-Wformat warnings with clang)
Branches: master, remotes/origin/master
Follows: release-4.5
Precedes: 

    Fix -Woverloaded-virtual warnings when building with clang

    Satisfy clang by removing option for non-nested signature printing from
    implementations of printsig and declare derived_probe::printsig with
'override'.

    Add function derived_probe::printsig_nonest to perform non-nested signature
    printing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/27940] The /* pc=0x... */ is no longer printed by "stap -v -L 'kernel.function("*")'

[wcohen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27940

--- Comment #1 from William Cohen <wcohen at redhat dot com> ---
Before the commit was made printscript in main.cxx:180 was:

                      p->printsig(sig, false);

This would end up calling the following method in tapsets.cxx where p is type
(derived_probe *):

dwarf_derived_probe::printsig (ostream& o, bool nest) const

However, after the commit the main.cxx:180 becomes:

                      p->printsig_nonest(sig);

The code in printscript ends up calling the following method in staptree.cxx:

void probe::printsig (ostream& o) const

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/27940] The /* pc=0x... */ is no longer printed by "stap -v -L 'kernel.function("*")'

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27940

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fche at redhat dot com,
                   |                            |tbaeder at redhat dot com

--- Comment #2 from Frank Ch. Eigler <fche at redhat dot com> ---
Yeah it looks like the conversion to fork into _nest and _nonest was not
complete/accurate.  Unless Tim might want to have a second go at it, we'd need
to revert this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/27940] The /* pc=0x... */ is no longer printed by "stap -v -L 'kernel.function("*")'

[dichen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27940

Di Chen <dichen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dichen at redhat dot com
           Assignee|systemtap at sourceware dot org    |dichen at redhat dot com

-- 
You are receiving this mail because:
You are the assignee for the bug.