From: "dannf at dannf dot org" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug uprobes/28923] dtrace predictable temp file causes race
Date: Fri, 25 Feb 2022 16:06:41 +0000 [thread overview]
Message-ID: <bug-28923-6586-wjZBfxXYM8@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28923-6586@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=28923
--- Comment #2 from dann frazier <dannf at dannf dot org> ---
Thanks for the response Frank!
I suspect the flock() approach could have unintended side-effects depending on
the underlying filesystem. I don't have a specific example. Much like a
toddler's birthday party, it's just something I've learned is better to avoid
over the years.
I do like the idea of providing a salt to the mkstemp function. Although,
probably not with the content of the input file alone because, in the libvirt
case, that input is actually the same. The passed-in path is unique though, so
that would seem to work.
Just to make sure we're not reinventing the wheel, I reached out to the
reproducible builds folks to see if they know of a way to override .file when
generating C files:
https://lists.reproducible-builds.org/pipermail/rb-general/2022-February/002489.html
I suggest we see if they have a better idea. Meanwhile, I'll try to PoC a
filename-seeded-mkstemp patch.
--
You are receiving this mail because:
You are the assignee for the bug.
next prev parent reply other threads:[~2022-02-25 16:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 0:12 [Bug uprobes/28923] New: " dannf at dannf dot org
2022-02-25 2:07 ` [Bug uprobes/28923] " fche at redhat dot com
2022-02-25 16:06 ` dannf at dannf dot org [this message]
2022-02-25 23:29 ` dannf at dannf dot org
2022-02-26 1:14 ` fche at redhat dot com
2022-02-26 16:21 ` dannf at dannf dot org
2022-02-28 17:33 ` dannf at dannf dot org
2022-03-01 16:06 ` fche at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-28923-6586-wjZBfxXYM8@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).