From: "mcermak at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/29765] New: Convert NFS from readpages to readahead => tapset/linux/nfs.stp breakage
Date: Wed, 09 Nov 2022 12:57:17 +0000 [thread overview]
Message-ID: <bug-29765-6586@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=29765
Bug ID: 29765
Summary: Convert NFS from readpages to readahead =>
tapset/linux/nfs.stp breakage
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: runtime
Assignee: systemtap at sourceware dot org
Reporter: mcermak at redhat dot com
Target Milestone: ---
Kernel commit 8786fde84 (Convert NFS from readpages to readahead) breaks the
tapset/linux/nfs.stp (stap commit 7eed8d1fe):
semantic error: while resolving probe point: identifier 'module' at
/usr/local/share/systemtap/tapset/linux/nfs.stp:976:27
source: module("nfs").function
("nfs_readpages")
Linux kernel change:
commit 8786fde8421ce755a842051f9528674a1b1f0b9a
Author: Matthew Wilcox (Oracle) <willy@infradead.org>
Date: Sat Jan 22 20:54:52 2022 +0000
Convert NFS from readpages to readahead
NFS is one of the last two users of the deprecated ->readpages aop.
This conversion looks straightforward, but I have only compile-tested
it.tapset/linux/nfs.stp
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Reproducer using 5.14.0-186.kpq1.el9:
# cat readpages.stp
probe nfs.aop.readpages {
log(name);
printf("dev=%d\n", dev);
printf("ino=%d\n", ino);
printf("nr_pages=%d\n", nr_pages);
printf("file=%d\n", file);
printf("rpages=%d\n", rpages);
printf("rsize=%d\n", rsize);
printf("argstr=%s\n", argstr);
printf("size=%d\n", size);
printf("units=%s\n", units);
}
probe nfs.aop.readpages.return {
log(name);
printf("retstr=%s\n", retstr);
printf("size=%d\n", size);
printf("units=%s\n", units);
}
# stap -vp4 readpages.stp
Pass 1: parsed user script and 472 library scripts using
123716virt/102716res/8432shr/94144data kb, in 570usr/120sys/910real ms.
semantic error: while resolving probe point: identifier 'module' at
/usr/local/share/systemtap/tapset/linux/nfs.stp:976:27
source: module("nfs").function
("nfs_readpages")
^
semantic error: no match (similar functions: nfs_readpage, nfs_readahead,
nfs_writepages, nfs_readdir, nfs_readpage_done)
semantic error: resolution failed in alias expansion builder
semantic error: while resolving probe point: identifier 'nfs' at
readpages.stp:1:7
source: probe nfs.aop.readpages {
^
semantic error: no match
semantic error: while resolving probe point: identifier 'module' at
/usr/local/share/systemtap/tapset/linux/nfs.stp:995:34
source: module("nfs").function
("nfs_readpages").return
^
semantic error: resolution failed in alias expansion builder
Pass 2: analyzed script: 0 probes, 0 functions, 0 embeds, 0 globals using
190100virt/170936res/10092shr/160528data kb, in 2250usr/650sys/2903real ms.
Pass 2: analysis failed. [man error::pass2]
#
--
You are receiving this mail because:
You are the assignee for the bug.
next reply other threads:[~2022-11-09 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 12:57 mcermak at redhat dot com [this message]
2023-05-17 15:09 ` [Bug runtime/29765] " mcermak at redhat dot com
2023-05-18 16:50 ` fche at redhat dot com
2023-05-19 9:07 ` mcermak at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-29765-6586@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).