From: "wcohen at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/30401] s390x specific: invalid application of ‘sizeof’ to incomplete type ‘struct stack_frame’
Date: Fri, 06 Oct 2023 21:03:16 +0000 [thread overview]
Message-ID: <bug-30401-6586-QFBtCYqioM@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30401-6586@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=30401
William Cohen <wcohen at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |wcohen at redhat dot com
--- Comment #1 from William Cohen <wcohen at redhat dot com> ---
I investigationed why this is failing on rhel9 s390. The struct stack_frame
was moved arch/s390/include/asm/processor.h to
arch/s390/include/asm/stackframe.h by kernel
git commit 78c98f9074135d3dab4e39544e0a537f92388fce
Author: Martin Schwidefsky <schwidefsky@de.ibm.com> 2019-01-28 02:33:08
Committer: Martin Schwidefsky <schwidefsky@de.ibm.com> 2019-05-02 07:54:11
Parent: 1c705ad5efae9c712e763a47fbcc95b87b7347d2 (s390/opcodes: add missing
instructions to the disassembler)
Child: ec7bf4789d95a0053bac0dfa36fbefd8cc584eea (s390/ftrace: use
HAVE_FUNCTION_GRAPH_RET_ADDR_PTR)
Branches: master, remotes/origin/master, remotes/origin/mmu_gather-race-fix,
remotes/origin/tty-splice, remotes/origin/x86-rep-insns,
remotes/origin/x86-uaccess-cleanup, wcohen/gcc9
Follows: v5.1-rc2
Precedes: v5.2-rc1
s390/unwind: introduce stack unwind API
Rework the dump_trace() stack unwinder interface to support different
unwinding algorithms. The new interface looks like this:
struct unwind_state state;
unwind_for_each_frame(&state, task, regs, start_stack)
do_something(state.sp, state.ip, state.reliable);
The unwind_bc.c file contains the implementation for the classic
back-chain unwinder.
One positive side effect of the new code is it now handles ftraced
functions gracefully. It prints the real name of the return function
instead of 'return_to_handler'.
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
I am looking around to see there is a common include that ends up pulling in
the definition of struct stack_frame. The patch above adds "#include
<asm/stacktrace.h>" a number of files. Might need to resort to a STAPCONF to
add the include where needed.
--
You are receiving this mail because:
You are the assignee for the bug.
next prev parent reply other threads:[~2023-10-06 21:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 12:33 [Bug runtime/30401] New: " mcermak at redhat dot com
2023-10-06 21:03 ` wcohen at redhat dot com [this message]
2023-10-12 3:45 ` [Bug runtime/30401] " wcohen at redhat dot com
2023-10-12 9:17 ` sam at gentoo dot org
2023-10-12 17:59 ` wcohen at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-30401-6586-QFBtCYqioM@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).