[Bug runtime/30416] New: unable to find member 'request' for struct scsi_cmnd

[Bug runtime/30416] New: unable to find member 'request' for struct scsi_cmnd

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30416

            Bug ID: 30416
           Summary: unable to find member 'request' for struct scsi_cmnd
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: mcermak at redhat dot com
  Target Milestone: ---

Following is one of the problems CI gating shows for systemtap-4.9-1.fc39:

Testcase:  /tests/Regression/semantic-errors-bz1062076
Output:

:: [ 22:01:51 ] :: [  BEGIN   ] :: Running 'stap -P -vp4 script.stp'
Pass 1: parsed user script and 495 library scripts using
140024virt/111044res/15744shr/94676data kb, in 140usr/20sys/158real ms.
semantic error: unable to find member 'request' for struct scsi_cmnd
(alternatives: result, retries, sdb, rcu, cmnd, eh_entry, flags, state, device,
allowed, cmd_len, extra_len, prot_op, prot_sdb, sense_len, eh_eflags,
resid_len, underflow, abort_work, prot_type, submitter, prot_flags,
sense_buffer, transfersize, budget_token, host_scribble, sc_data_direction,
jiffies_at_alloc): operator '->' at
/usr/share/systemtap/tapset/linux/scsi.stp:189:66
        source:         return timer_pending(&@cast(cmd, "scsi_cmnd",
"kernel:scsi_mod")->request->q->timeout)
                                                                               
        ^

Probable cause is the following kernel commit:

$ git show 2266a2def97ce11ec979b6c58a1b637a16eca7dd
commit 2266a2def97ce11ec979b6c58a1b637a16eca7dd
Author: Bart Van Assche <bvanassche@acm.org>
Date:   Mon Aug 9 16:03:55 2021 -0700

    scsi: core: Remove the request member from struct scsi_cmnd

    Since all scsi_cmnd.request users are gone, remove the request pointer
    from struct scsi_cmnd.

    Link: https://lore.kernel.org/r/20210809230355.8186-53-bvanassche@acm.org
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Hannes Reinecke <hare@suse.de>
    Cc: Ming Lei <ming.lei@redhat.com>
    Signed-off-by: Bart Van Assche <bvanassche@acm.org>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/30416] unable to find member 'request' for struct scsi_cmnd

[wcohen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30416

William Cohen <wcohen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |wcohen at redhat dot com

--- Comment #1 from William Cohen <wcohen at redhat dot com> ---
This has been addressed by systemtap git commit
e94d0e3deb34e684ca83573d7d2bc9b382db2427

    Have the scsi tapset support newer kernels struct scsi_cmnd

    The linux kernel commit 2266a2def97ce11ec removed the request field
    from struct scsi_cmnd.  The scsi tapset needed to test whether the
    request field is available.  If request field is not available, use
    the linux kernels helper function scsi_cmd_to_rq to get a value for
    request.

-- 
You are receiving this mail because:
You are the assignee for the bug.