public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* [Bug runtime/31051] New: Error handling is incomplete in the early uprobe registration code
@ 2023-11-11  5:50 agentzh at gmail dot com
  2023-11-14 19:39 ` [Bug runtime/31051] " agentzh at gmail dot com
  2023-11-14 20:49 ` agentzh at gmail dot com
  0 siblings, 2 replies; 3+ messages in thread
From: agentzh at gmail dot com @ 2023-11-11  5:50 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=31051

            Bug ID: 31051
           Summary: Error handling is incomplete in the early uprobe
                    registration code
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: agentzh at gmail dot com
  Target Milestone: ---

Systemtap 5.0 introduced the early uprobe registration (module init time) as a
performance optimization. Unfortunately, it does not handle the errors very
well. For example, when uprobe_register() failed, there would be memory leaks
and leftover uprobes (resulting in kernel panics).

I'll prepare a patch to address this new regression.

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug runtime/31051] Error handling is incomplete in the early uprobe registration code
  2023-11-11  5:50 [Bug runtime/31051] New: Error handling is incomplete in the early uprobe registration code agentzh at gmail dot com
@ 2023-11-14 19:39 ` agentzh at gmail dot com
  2023-11-14 20:49 ` agentzh at gmail dot com
  1 sibling, 0 replies; 3+ messages in thread
From: agentzh at gmail dot com @ 2023-11-14 19:39 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=31051

--- Comment #1 from agentzh <agentzh at gmail dot com> ---
In response to fche's request, below is a minimal test case that reproduces the
memory leaks and uprobe leaks:

https://gist.github.com/agentzh/814dafd2d6c8a661c7d23cbdc96e5d28

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug runtime/31051] Error handling is incomplete in the early uprobe registration code
  2023-11-11  5:50 [Bug runtime/31051] New: Error handling is incomplete in the early uprobe registration code agentzh at gmail dot com
  2023-11-14 19:39 ` [Bug runtime/31051] " agentzh at gmail dot com
@ 2023-11-14 20:49 ` agentzh at gmail dot com
  1 sibling, 0 replies; 3+ messages in thread
From: agentzh at gmail dot com @ 2023-11-14 20:49 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=31051

agentzh <agentzh at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #2 from agentzh <agentzh at gmail dot com> ---
Fixed in commit 0fef0bd60ff4

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-11-14 20:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-11  5:50 [Bug runtime/31051] New: Error handling is incomplete in the early uprobe registration code agentzh at gmail dot com
2023-11-14 19:39 ` [Bug runtime/31051] " agentzh at gmail dot com
2023-11-14 20:49 ` agentzh at gmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).