[Bug translator/31119] New: did not escape Golang program symbol name

[Bug translator/31119] New: did not escape Golang program symbol name

[lijunlong at openresty dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31119

            Bug ID: 31119
           Summary: did not escape Golang program symbol name
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: translator
          Assignee: systemtap at sourceware dot org
          Reporter: lijunlong at openresty dot com
  Target Milestone: ---

Created attachment 15242
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15242&action=edit
did not escape golang symbol

1. golang's symbol name may contain double quotation marks.

For example:
```
<386a40>   DW_AT_name        : *struct { Rates map[string]float64
"json:\"rate_by_service\"" }

```

2. get char from cpp string singed extended would get the wrong result.

```
(unsigned)str[I] is equal to (unsigned)(int)str[i]
```

We need to change to (unsigned char)str[i]

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/31119] did not escape Golang program symbol name

[lijunlong at openresty dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31119

--- Comment #1 from lijunlong <lijunlong at openresty dot com> ---
Comment on attachment 15242
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15242
did not escape golang symbol

commit d10ae580f8791606739ae6bfa7db7277d6921cc9
Author: lijunlong <lijunlong@openresty.com>
Date:   Thu Dec 7 10:49:37 2023 +0800

    bugfix: escape char should cast to 'unsigned char' instead of 'unsigned'.

diff --git a/util.cxx b/util.cxx
index f2eaf54f4..7a1081654 100644
--- a/util.cxx
+++ b/util.cxx
@@ -1301,10 +1301,9 @@ octal_character (unsigned c)
   return '0' + c % 8;
 }

-string
-escaped_character (unsigned c)
+static inline void
+escaped_character_impl (unsigned c, ostringstream &o)
 {
-  ostringstream o;
   int oc = (int)c;

   switch (oc)
@@ -1362,18 +1361,28 @@ escaped_character (unsigned c)
             << octal_character(oc);
         }
     }
+}
+
+string
+escaped_character (unsigned c)
+{
+  ostringstream o;
+
+  escaped_character_impl(c, o);
+
   return o.str();
 }

 string
 escaped_literal_string (const string& str)
 {
-  string op;
+  ostringstream o;
+
   for (unsigned i = 0; i < str.size (); i++)
     {
-      op += escaped_character((unsigned)str[i]);
+      escaped_character_impl((unsigned char)str[i], o);
     }
-  return op;
+  return o.str();
 }

 string

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/31119] did not escape Golang program symbol name

[lijunlong at openresty dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31119

--- Comment #2 from lijunlong <lijunlong at openresty dot com> ---
Comment on attachment 15242
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15242
did not escape golang symbol

commit d10ae580f8791606739ae6bfa7db7277d6921cc9
Author: lijunlong <lijunlong@openresty.com>
Date:   Thu Dec 7 10:49:37 2023 +0800

    bugfix: escape char should cast to 'unsigned char' instead of 'unsigned'.

diff --git a/util.cxx b/util.cxx
index f2eaf54f4..7a1081654 100644
--- a/util.cxx
+++ b/util.cxx
@@ -1301,10 +1301,9 @@ octal_character (unsigned c)
   return '0' + c % 8;
 }

-string
-escaped_character (unsigned c)
+static inline void
+escaped_character_impl (unsigned c, ostringstream &o)
 {
-  ostringstream o;
   int oc = (int)c;

   switch (oc)
@@ -1362,18 +1361,28 @@ escaped_character (unsigned c)
             << octal_character(oc);
         }
     }
+}
+
+string
+escaped_character (unsigned c)
+{
+  ostringstream o;
+
+  escaped_character_impl(c, o);
+
   return o.str();
 }

 string
 escaped_literal_string (const string& str)
 {
-  string op;
+  ostringstream o;
+
   for (unsigned i = 0; i < str.size (); i++)
     {
-      op += escaped_character((unsigned)str[i]);
+      escaped_character_impl((unsigned char)str[i], o);
     }
-  return op;
+  return o.str();
 }

 string

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/31119] did not escape Golang program symbol name

[wcohen at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31119

William Cohen <wcohen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wcohen at redhat dot com

--- Comment #3 from William Cohen <wcohen at redhat dot com> ---
Could you provide a simple go program reproducer for this?

-- 
You are receiving this mail because:
You are the assignee for the bug.