[Bug uprobes/31519] New: sys/sdt.h causes compiler warnings when compiling with C++

[Bug uprobes/31519] New: sys/sdt.h causes compiler warnings when compiling with C++

[carl.shapiro at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31519

            Bug ID: 31519
           Summary: sys/sdt.h causes compiler warnings when compiling with
                    C++
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: uprobes
          Assignee: systemtap at sourceware dot org
          Reporter: carl.shapiro at gmail dot com
  Target Milestone: ---

Created attachment 15424
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15424&action=edit
patch for sys/sdt.h

We are seeing the following warning when using sys/sdt.h from C++

sys/sdt.h:471:5: warning: "__STDC_VERSION__" is not defined, evaluates to 0
[-Wundef]

According to the GCC documentation, __STDC_VERSION__ is not defined when
compiling C++

https://gcc.gnu.org/onlinedocs/cpp/Standard-Predefined-Macros.html

The following is the only use of __STDC_VERSION__ in sys/sdt.h

#if __STDC_VERSION__ >= 199901L

and checking if __STDC_VERSION__ is defined is enough to make the warning go
away

#if defined(__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L)

I think this is the only place where checking for a macro definition is done
before using its value.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug uprobes/31519] sys/sdt.h causes compiler warnings when compiling with C++

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31519

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fche at redhat dot com
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> ---
thanks, merged!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug uprobes/31519] sys/sdt.h causes compiler warnings when compiling with C++

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31519

--- Comment #2 from Frank Ch. Eigler <fche at redhat dot com> ---
thanks, merged!

-- 
You are receiving this mail because:
You are the assignee for the bug.