public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "wcohen at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/31597] New: Systemtap not extracting all the data sent to the print data in the buffers before shutdown
Date: Tue, 02 Apr 2024 19:13:29 +0000	[thread overview]
Message-ID: <bug-31597-6586@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=31597

            Bug ID: 31597
           Summary: Systemtap not extracting all the data sent to the
                    print data in the buffers before shutdown
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: wcohen at redhat dot com
  Target Milestone: ---

When reviewing the tests results for the syscall.exp tests different runs of
the same tests would have different tests fail.  The syscall.exp tests should
be deterministics, but they are not. Note even those the second and third run
have same number of passes there are difference in which specific tests passed.
Four different runs of:

sudo make installcheck RUNTESTFLAGS=syscall.exp


                === systemtap Summary ===

# of expected passes            302
# of unexpected failures        38
# of untested testcases         1
# of unsupported tests          4

                === systemtap Summary ===

# of expected passes            299
# of unexpected failures        41
# of untested testcases         1
# of unsupported tests          4

                === systemtap Summary ===

# of expected passes            299
# of unexpected failures        41
# of untested testcases         1
# of unsupported tests          4

                === systemtap Summary ===

# of expected passes            295
# of unexpected failures        45
# of untested testcases         1
# of unsupported tests          4

One of the things that this test does is use the -c option to shut down the
systemtap instrumentation when the user-space command completes.  However, it
appears that the shutdown sometimes happens too quickly and some of the print
output saved in the buffer has not been read out of the buffers, causing the
output to be truncated and the test to fail.  To test this hypothesis I put
"sleep(1);" before the "stop_threads = 1;" in close_relayfs() and
kill_relayfs() functions in staprun/relay.c.  I compared the systemtap.sum
output for the delayed shutdown.  The only changes were the additional PASS in
the version with the failure. There were no FAIL: in the delayed version where
the previous 4 runs has PASS:.

-- 
You are receiving this mail because:
You are the assignee for the bug.

             reply	other threads:[~2024-04-02 19:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 19:13 wcohen at redhat dot com [this message]
2024-04-17 14:42 ` [Bug runtime/31597] " wcohen at redhat dot com
2024-04-26 15:56 ` wcohen at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31597-6586@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).