[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[lars at pixar dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=6562

Lars R. Damerow <lars at pixar dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lars at pixar dot com

--- Comment #16 from Lars R. Damerow <lars at pixar dot com> ---
Argh, didn't realize commenting would reopen. Sorry about that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[Josh Stone]

On 03/19/2014 03:21 PM, lars at pixar dot com wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=6562
> 
> Lars R. Damerow <lars at pixar dot com> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |lars at pixar dot com
> 
> --- Comment #16 from Lars R. Damerow <lars at pixar dot com> ---
> Argh, didn't realize commenting would reopen. Sorry about that.

Lars,

I assume you're talking about your PR16719 comment; note this second
comment is on PR6562.  You haven't affect the status of either.

Consider changing the bugzilla preference for "After changing a bug:" to
"Show the updated bug".  The default is "Show the next bug in my list",
which I find is rarely what I want.

Josh

Re: [Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[Lars R. Damerow]

Yep, that's what happened. I glanced at the resulting page after my comment and saw "REOPENED", which made me think I'd done something bad.

What weird default behavior. Thanks for the tip and sorry for my confusion!

> On Mar 19, 2014, at 16:21, Josh Stone <jistone@redhat.com> wrote:
> 
>> On 03/19/2014 03:21 PM, lars at pixar dot com wrote:
>> https://sourceware.org/bugzilla/show_bug.cgi?id=6562
>> 
>> Lars R. Damerow <lars at pixar dot com> changed:
>> 
>>           What    |Removed                     |Added
>> ----------------------------------------------------------------------------
>>                 CC|                            |lars at pixar dot com
>> 
>> --- Comment #16 from Lars R. Damerow <lars at pixar dot com> ---
>> Argh, didn't realize commenting would reopen. Sorry about that.
> 
> Lars,
> 
> I assume you're talking about your PR16719 comment; note this second
> comment is on PR6562.  You haven't affect the status of either.
> 
> Consider changing the bugzilla preference for "After changing a bug:" to
> "Show the updated bug".  The default is "Show the next bug in my list",
> which I find is rarely what I want.
> 
> Josh
> 

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[fche at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=6562

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fche at redhat dot com
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #17 from Frank Ch. Eigler <fche at redhat dot com> ---
moot with elfutils/debuginfod support

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[srikar at linux dot vnet dot ibm dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|srinivasa at in dot ibm dot |srikar at linux dot vnet dot
                   |com                         |ibm dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[srikar at linux dot vnet dot ibm dot com]

------- Additional Comments From srikar at linux dot vnet dot ibm dot com  2009-02-02 09:10 -------
>  
> Did it fail in distribution kernel? Currently, DEBUGINFO_PATH of test case is
> hardcoded to self-built kernel.
> 

Even with 8e6335965169b37a977fd923ddf7bbe9fd5c3aef;
debugpath.exp still seems to fail in some distros while passing on others. 
Looks like when SYSTEMTAP_DEBUGINFO_PATH is set, elfutils only looks for vmlinux
and vmlinux.debug. However the debuginfo file may be named as vmlinux-$uname.debug.

I am seeing this problem in Opensuse.
Can we 

1. Make elfutils to parse vmlinux-$uname and vmlinux-$uname.debug

 or

2. Make this testcase a known failure (KFAIL)



-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[srinivasa at in dot ibm dot com]

------- Additional Comments From srinivasa at in dot ibm dot com  2008-10-21 06:32 -------
(In reply to comment #13)
> Sorry, I didn't know about this open bug report.
> I recently worked around this issue with:
> 

Mark

Patch looks good to me and I tested it on my system, It works well.

Host: Linux llm27lp1.in.ibm.com 2.6.27-rc7 #2 SMP Mon Oct 20 14:16:58 IST 2008
ppc64 ppc64 ppc64 GNU/Linux
Snapshot: b0ff684d5ac5b0ade97a4e508a92a7f743068221
Distro: Red Hat Enterprise Linux Server release 5.2 Beta (Tikanga)

Running /home/sources/src/testsuite/systemtap.base/debugpath.exp ...

                === systemtap Summary ===

# of expected passes            2



-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[mjw at redhat dot com]

------- Additional Comments From mjw at redhat dot com  2008-10-20 18:58 -------
Sorry, I didn't know about this open bug report.
I recently worked around this issue with:

commit 8e6335965169b37a977fd923ddf7bbe9fd5c3aef
Author: Mark Wielaard <mjw@redhat.com>
Date:   Sat Oct 4 17:38:07 2008 +0200

    Guess where debuginfo is installed for debugpath.exp test.

diff --git a/testsuite/ChangeLog b/testsuite/ChangeLog
index 041df49..5ddee32 100644
--- a/testsuite/ChangeLog
+++ b/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2008-10-04  Mark Wielaard  <mjw@redhat.com>
+
+       * systemtap.base/debugpath.exp: Guess a bit more intelligently
+       where debuginfo is installed.

Could you see if that is an acceptable solution?

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2008-10-20 15:14 -------
Srinivasa DS wrote:
> I will modify the testcase, so that it shouldn't throw FAIL status on distro
kernel.

Ping.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[srinivasa at in dot ibm dot com]

------- Additional Comments From srinivasa at in dot ibm dot com  2008-07-11 10:47 -------
(In reply to comment #10)
> (In reply to comment #9)
> > Could you investigate please why the testsuite/systemtap.base/debugpath.exp
> > debugpath-good has started failing due to this commit?
> > 
> In self-built kernel, it works fine. Maybe sometime timeout.
>  
> Did it fail in distribution kernel? Currently, DEBUGINFO_PATH of test case is
> hardcoded to self-built kernel.


I have set the SYSTEMTAP_DEBUGINFO_PATH=/lib/modules/`uname -r`/build  in
debugpath.exp and hence it works fine on self built kernel and fails on distro
kernel. 
I will modify the testcase, so that it shouldn't throw FAIL status on distro kernel.

Thanks
 Srinivasa DS


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2008-07-11 03:22 -------
(In reply to comment #9)
> Could you investigate please why the testsuite/systemtap.base/debugpath.exp
> debugpath-good has started failing due to this commit?
> 
In self-built kernel, it works fine. Maybe sometime timeout.
 
Did it fail in distribution kernel? Currently, DEBUGINFO_PATH of test case is
hardcoded to self-built kernel.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2008-07-10 16:48 -------
Could you investigate please why the testsuite/systemtap.base/debugpath.exp
debugpath-good has started failing due to this commit?


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |srinivasa at in dot ibm dot
                   |                            |com
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2008-06-03 21:04 -------
Appears fixed in commit 921d6103.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[ananth at in dot ibm dot com]

------- Additional Comments From ananth at in dot ibm dot com  2008-05-29 06:16 -------
Sounds good!

Can you please check the patch in?

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[srinivasa at in dot ibm dot com]

------- Additional Comments From srinivasa at in dot ibm dot com  2008-05-29 05:57 -------
(In reply to comment #5)
> Srini,
> Will your patch work for modules? Do we still look under /lib/modules/`uname -r`/?
> If so, great!

Elfutils doesn't allow us to specify different paths for vmlinux and modules(
except in one case where vmlinux is searched in /boot and modules in
/lib/modules/uname -r, this because these paths are hardcoded).

So when we specify path in SYSTEMTAP_DEBUGINFO_PATH, elfutils searches modules
in that path, 
for eg:- [root@llm27lp1 src]# export
SYSTEMTAP_DEBUGINFO_PATH=/home/srini/systemtap/linux-2.6.26-rc3

Then elfutils searches modules in subdirs of /home/srini/systemtap/linux-2.6.26-rc3

[root@llm27lp1 src]# ./stap -vvv -e 'probe
module("ext3").function("ext3_group_extend") { printf("hi\n")}'
........................................
 .......................................
focused on module 'ext3 = [0x4f0200-0x518100, bias 0x0] file
/home/srini/systemtap/linux-2.6.26-rc3/fs/ext3/ext3.ko ELF machine ppc64 (code 21)
...........................
====================================

> 
> Another option for helping folks who'd want to use SystemTap with their self
> built kernels, but without sufficient /boot/ space is to make elfutils
> intelligent to look for /lib/modules/`uname -r`/build/vmlinux

This can be solved by above patch, just set
export SYSTEMTAP_DEBUGINFO_PATH=/lib/modules/`uname -r`/build/, elfutils
searches vmlinux and modules in same dir.


> 
> Ananth



-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[ananth at in dot ibm dot com]

------- Additional Comments From ananth at in dot ibm dot com  2008-05-28 15:33 -------
Srini,
Will your patch work for modules? Do we still look under /lib/modules/`uname -r`/?
If so, great!

Another option for helping folks who'd want to use SystemTap with their self
built kernels, but without sufficient /boot/ space is to make elfutils
intelligent to look for /lib/modules/`uname -r`/build/vmlinux

Ananth

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[fche at redhat dot com]

------- Additional Comments From fche at redhat dot com  2008-05-28 15:30 -------
(In reply to comment #3)
> Created an attachment (id=2761)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2761&action=view)
> Patch to specify absolute path from SYSTEMTAP_DEBUGINFO_PATH variable

Looks plausible to me.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[srinivasa at in dot ibm dot com]

------- Additional Comments From srinivasa at in dot ibm dot com  2008-05-28 15:05 -------
Created an attachment (id=2761)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2761&action=view)
Patch to specify absolute path from SYSTEMTAP_DEBUGINFO_PATH variable

This patch makes us to assign absolute path to SYSTEMTAP_DEBUGINFO_PATH
environment variable.
eg:- export SYSTEMTAP_DEBUGINFO_PATH=/home/srini/systemtap/linux-2.6.26-rc3

This will make systemtap to look for vmlinux in SYSTEMTAP_DEBUGINFO_PATH dir
and resolves symbol based on that.

dwfl_linux_kernel_report_offline() of elfutils library allows us to pass
absolute path for searching debuginfo. Incase if SYSTEMTAP_DEBUGINFO_PATH is
not set, systemtap passes kernel_release string and hence debuginfo is searched
in /boot/vmlinux-`uname -r` or /lib/modules/.

Please let me know your comments.

Thanks
 Srinivasa DS 

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[prasad at linux dot vnet dot ibm dot com]

------- Additional Comments From prasad at linux dot vnet dot ibm dot com  2008-05-27 15:57 -------
Hi Wenji,
        Thanks for letting me know the same. I tried running the scripts by
placing the vmlinux image and it works fine.

However, I'm wondering if it would be desirable to specify absolute paths (and
not just the parent directory) using $SYSTEMTAP_DEBUGINFO_PATH.

Thanks,
K.Prasad


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wenji dot huang at oracle
                   |                            |dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/6562] $SYSTEMTAP_DEBUGINFO_PATH does not work

[wenji dot huang at oracle dot com]

------- Additional Comments From wenji dot huang at oracle dot com  2008-05-27 09:23 -------
Subject: Re:  New: $SYSTEMTAP_DEBUGINFO_PATH does not work

prasad at linux dot vnet dot ibm dot com wrote:
[...]
 > [root@prasadkr_t60p systemtap]# env | grep DEBUG
 > SYSTEMTAP_DEBUGINFO_PATH=/home/prasadkr/tryvmlinux/
 > [root@prasadkr_t60p systemtap]# ls -lh /home/prasadkr/tryvmlinux/
 > total 72M

The debuginfo_path is a little weird. If we specify it begins with "/",
such as "/home/prasadkr/tryvmlinux/", the real searching path will be 
"/home/prasadkr/tryvmlinux/lib/modules/xxx/vmlinux".

And the relative path will begin with /lib/modules/xxx/, like "build"

So you can make some addition under "tyrvmlinux" and take another test.

I suggest that debugpath.exp should be strengthened to cover the 
self-built kernel case.

diff --git a/testsuite/systemtap.base/debugpath.exp 
b/testsuite/systemtap.base/debugpath.exp
index b0b1220..b6e5674 100644
--- a/testsuite/systemtap.base/debugpath.exp
+++ b/testsuite/systemtap.base/debugpath.exp
@@ -10,7 +10,7 @@ expect {
  wait

  set test "debugpath-good"
-spawn env SYSTEMTAP_DEBUGINFO_PATH=:/usr/lib/debug stap -e "probe 
kernel.function(\"sys_open\") {}" -p2
+spawn env SYSTEMTAP_DEBUGINFO_PATH=:/usr/lib/debug:build stap -e "probe 
kernel.function(\"sys_open\") {}" -p2
  expect {
         -re {kernel.function.*pc=} { pass $test }
         timeout { fail "$test (timeout2)" }


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6562

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.