public inbox for xconq7@sourceware.org
 help / color / mirror / Atom feed
From: Eric McDonald <mcdonald@phy.cmich.edu>
To: Hans Ronne <hronne@comhem.se>
Cc: xconq7@sources.redhat.com
Subject: Re: The selective fire-at command
Date: Tue, 17 Aug 2004 22:59:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.44.0408171807480.32437-100000@leon.phy.cmich.edu> (raw)
In-Reply-To: <l03130300bd481c4cb915@[212.181.162.155]>

On Tue, 17 Aug 2004, Hans Ronne wrote:

> You will notice that the pixel coordinates are converted to (x, y) by
> nearest_cell, and these cell coordinates are then passed on to
> common_fire_at. What this means is that all information about what unit
> within the cell you were trying to target is lost.

Right, and that caused problems later on when one needed more 
information in the 'common_fire_at' routine.

>         if (unit->side != side_n(uview->siden)) {
>             other = uview->unit;
>             /* Assume we have the right target. (Bad assumption,
>                but what else can one do with the info presently available?) */

I think the comment says it all. The function did what it could 
with the info available.

> Now, two comments. First, the fire-at command does work in the Mac
> interface since the pixel coordinates are passed on and the unit under the
> cursor is identified. 

I think that when I was working on the Dec 29 fix, I wanted to fix 
this as well, but wasn't sure how to go about it because I didn't 
know the Tcl/Tk interface code all that well. In retrospect, I 
should have looked at the attack code for guidance.

Eric

  reply	other threads:[~2004-08-17 22:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-17 22:15 Hans Ronne
2004-08-17 22:59 ` Eric McDonald [this message]
2004-08-17 23:25   ` Hans Ronne
2004-08-17 23:36     ` Eric McDonald
2004-08-18  0:48       ` Hans Ronne
2004-08-18  3:00         ` Eric McDonald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0408171807480.32437-100000@leon.phy.cmich.edu \
    --to=mcdonald@phy.cmich.edu \
    --cc=hronne@comhem.se \
    --cc=xconq7@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).