* [expr-cumulative] Fix return type qualifier
@ 2009-10-23 19:46 Jan Kratochvil
2009-10-23 19:55 ` Tom Tromey
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kratochvil @ 2009-10-23 19:46 UTC (permalink / raw)
To: Sami Wagiaalla; +Cc: archer
Hi Sami,
OK to check-in?
gcc-4.1.2-46.el5_4.1.x86_64
errors due to -Werror on:
gdb/dwarf2read.c:3642: warning: type qualifiers ignored on function return type
from code of
e7c98bbe4bea801d53222c3337cbae3f3944547c
Thanks,
Jan
* dwarf2read.c (dwarf2_read_decl_line): Fix excessive const return
qualifier. Fix GNU formatting style.
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -3357,14 +3357,17 @@ dwarf2_full_name (struct die_info *die, struct dwarf2_cu *cu)
return name;
}
-/* read the given die's decl_line number. Return -1 if in case of an error */
-static const int dwarf2_read_decl_line (struct die_info *die, struct dwarf2_cu *cu){
+/* Read the given DIE's DW_AT_decl_line number. Return -1 if in case of an
+ error. */
+
+static int
+dwarf2_read_decl_line (struct die_info *die, struct dwarf2_cu *cu)
+{
struct attribute *line_attr;
line_attr = dwarf2_attr (die, DW_AT_decl_line, cu);
- if (line_attr){
- return DW_UNSND (line_attr);
- }
+ if (line_attr)
+ return DW_UNSND (line_attr);
return -1;
}
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [expr-cumulative] Fix return type qualifier
2009-10-23 19:46 [expr-cumulative] Fix return type qualifier Jan Kratochvil
@ 2009-10-23 19:55 ` Tom Tromey
2009-10-23 19:59 ` Jan Kratochvil
0 siblings, 1 reply; 4+ messages in thread
From: Tom Tromey @ 2009-10-23 19:55 UTC (permalink / raw)
To: Jan Kratochvil; +Cc: Sami Wagiaalla, archer
Jan> Hi Sami,
Jan> OK to check-in?
Jan> * dwarf2read.c (dwarf2_read_decl_line): Fix excessive const return
Jan> qualifier. Fix GNU formatting style.
It qualifies as obvious, IMO.
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [expr-cumulative] Fix return type qualifier
2009-10-23 19:55 ` Tom Tromey
@ 2009-10-23 19:59 ` Jan Kratochvil
2009-10-23 20:24 ` Sami Wagiaalla
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kratochvil @ 2009-10-23 19:59 UTC (permalink / raw)
To: Tom Tromey; +Cc: Sami Wagiaalla, archer
On Fri, 23 Oct 2009 21:55:32 +0200, Tom Tromey wrote:
> Jan> * dwarf2read.c (dwarf2_read_decl_line): Fix excessive const return
> Jan> qualifier. Fix GNU formatting style.
>
> It qualifies as obvious, IMO.
I was rather not sure how it is with regards its import upstream, how much
relevant this part of the patch is (but probably not submitted according to my
grep).
Going to check it in.
Regards,
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [expr-cumulative] Fix return type qualifier
2009-10-23 19:59 ` Jan Kratochvil
@ 2009-10-23 20:24 ` Sami Wagiaalla
0 siblings, 0 replies; 4+ messages in thread
From: Sami Wagiaalla @ 2009-10-23 20:24 UTC (permalink / raw)
To: Jan Kratochvil; +Cc: Tom Tromey, archer
Jan Kratochvil wrote:
> On Fri, 23 Oct 2009 21:55:32 +0200, Tom Tromey wrote:
>> Jan> * dwarf2read.c (dwarf2_read_decl_line): Fix excessive const return
>> Jan> qualifier. Fix GNU formatting style.
>>
>> It qualifies as obvious, IMO.
>
Yup. Thanks for the fix.
> I was rather not sure how it is with regards its import upstream, how much
> relevant this part of the patch is (but probably not submitted according to my
> grep).
>
Yeah not submitted yet.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-10-23 20:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-23 19:46 [expr-cumulative] Fix return type qualifier Jan Kratochvil
2009-10-23 19:55 ` Tom Tromey
2009-10-23 19:59 ` Jan Kratochvil
2009-10-23 20:24 ` Sami Wagiaalla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).