public inbox for archer@sourceware.org
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <dan@codesourcery.com>
To: Roland McGrath <roland@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>, Chris Moller <cmoller@redhat.com>,
	Eric Bachalo <ebachalo@redhat.com>,
	Project Archer <archer@sourceware.org>
Subject: Re: PR 11067
Date: Wed, 03 Feb 2010 23:30:00 -0000	[thread overview]
Message-ID: <20100203232819.GK9493@caradoc.them.org> (raw)
In-Reply-To: <20100203232506.B073AAA@magilla.sf.frob.com>

On Wed, Feb 03, 2010 at 03:25:06PM -0800, Roland McGrath wrote:
> Yeah, I was going for parity and the /c format would not have been my first
> choice if we didn't already have it.  I think:
> 
> $2 = (enum frobozz) 1 = ENUM1
> 
> would be fine too, or maybe reverse the clauses.  "(type) digit" is
> probably what's most likely always to be pasteable anywhere, in case
> it's into a context where you don't have the same scope for the enum
> constant (in C++).

Something to consider is what contexts you want this output in.  I
think this would get old really fast:

$2 = { code = CODE_ADD = (enum code) 1, ops = OPS_TWO = (enum ops) 2 }

vs

$2 = { code = CODE_ADD, ops = OPS_TWO }
(gdb) p CODE_ADD
$3 = CODE_ADD = (enum code) 1

Hmm, can't say I like that format any better either, but there's got
to be a good one.  I usually p/d CODE_ADD to find out the value...

My takeaway point here is to consider the overall impact.

-- 
Daniel Jacobowitz
CodeSourcery

  reply	other threads:[~2010-02-03 23:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-02 22:12 patch for pr9067 Chris Moller
2010-02-02 23:28 ` Tom Tromey
2010-02-03  2:25   ` Chris Moller
2010-02-03 20:04     ` Tom Tromey
     [not found] ` <m3bpg7yznc.fsf@fleche.redhat.com>
     [not found]   ` <4B68DC25.1090808@redhat.com>
     [not found]     ` <m3fx5irwx6.fsf@fleche.redhat.com>
2010-02-03 21:52       ` PR 11067 Chris Moller
2010-02-03 22:43         ` Roland McGrath
2010-02-03 22:48           ` Tom Tromey
2010-02-03 23:14             ` Daniel Jacobowitz
2010-02-03 23:25               ` Roland McGrath
2010-02-03 23:30                 ` Daniel Jacobowitz [this message]
2010-02-03 23:34                   ` Chris Moller
2010-02-04  1:32                     ` Tom Tromey
2010-02-04 17:30                       ` Chris Moller
2010-02-04 23:53                         ` Tom Tromey
2010-02-05  0:29                           ` Chris Moller
2010-02-05 20:19                             ` Roland McGrath
2010-02-05 22:52                               ` Chris Moller
2010-02-03 23:21             ` Chris Moller
2010-02-03 22:47         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100203232819.GK9493@caradoc.them.org \
    --to=dan@codesourcery.com \
    --cc=archer@sourceware.org \
    --cc=cmoller@redhat.com \
    --cc=ebachalo@redhat.com \
    --cc=roland@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).