From: Chris Moller <cmoller@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Project Archer <archer@sourceware.org>
Subject: patch for pr9067
Date: Tue, 02 Feb 2010 22:12:00 -0000 [thread overview]
Message-ID: <4B68A35E.2050301@redhat.com> (raw)
Tom
I just sent $subject to gdb-patches. Turns out it was simultaneously
more complex and simpler than we both thought: You can't just blindly
inhibit multiple printings of static members. Sometimes it's
legitimate, like when they legitimately appear multiple times, possibly
on different paths through the tree. The simple side is that after I'd
finished writing a tree-path-aware fix for the bug, while I was testing
it, I noticed that someone had already stuck in an attempted fix, using
obstacks, but had screwed up their use. Not that I'm a big fan of
obstacks, but on the least-tinkering-possible principle, I scrapped my
new stuff and fixed the obstacks.
Chris
next reply other threads:[~2010-02-02 22:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 22:12 Chris Moller [this message]
2010-02-02 23:28 ` Tom Tromey
2010-02-03 2:25 ` Chris Moller
2010-02-03 20:04 ` Tom Tromey
[not found] ` <m3bpg7yznc.fsf@fleche.redhat.com>
[not found] ` <4B68DC25.1090808@redhat.com>
[not found] ` <m3fx5irwx6.fsf@fleche.redhat.com>
2010-02-03 21:52 ` PR 11067 Chris Moller
2010-02-03 22:43 ` Roland McGrath
2010-02-03 22:48 ` Tom Tromey
2010-02-03 23:14 ` Daniel Jacobowitz
2010-02-03 23:25 ` Roland McGrath
2010-02-03 23:30 ` Daniel Jacobowitz
2010-02-03 23:34 ` Chris Moller
2010-02-04 1:32 ` Tom Tromey
2010-02-04 17:30 ` Chris Moller
2010-02-04 23:53 ` Tom Tromey
2010-02-05 0:29 ` Chris Moller
2010-02-05 20:19 ` Roland McGrath
2010-02-05 22:52 ` Chris Moller
2010-02-03 23:21 ` Chris Moller
2010-02-03 22:47 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B68A35E.2050301@redhat.com \
--to=cmoller@redhat.com \
--cc=archer@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).