public inbox for archer@sourceware.org
 help / color / mirror / Atom feed
From: Chris Moller <cmoller@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Roland McGrath <roland@redhat.com>,
	Eric Bachalo <ebachalo@redhat.com>,
	Project Archer <archer@sourceware.org>
Subject: Re: PR 11067
Date: Wed, 03 Feb 2010 23:21:00 -0000	[thread overview]
Message-ID: <4B6A04DA.4040203@redhat.com> (raw)
In-Reply-To: <m3wryundfv.fsf@fleche.redhat.com>

On 02/03/10 17:48, Tom Tromey wrote:
>>>>>> "Roland" == Roland McGrath<roland@redhat.com>  writes:
>>>>>>              
>
> Roland>  I think it should use a format consistent with p/c, e.g.:
> Roland>  (gdb) p 'a'
> Roland>  $1 = 97 'a'
> Roland>  (gdb) p ENUM1
> Roland>  $2 = (enum frobozz) 1 ENUM1
>
> Works for me.  Chris, please do it this way, thanks.
>    

Okay, a whole 5-line patch yields

    (gdb) p e
    $1 = (enum E) 56 Val1
    (gdb) p Val1
    $2 = (enum E) 56 Val1
    (gdb)

(The enum, BTW, is

    num E {
       Val1 = 56,
       Val2
    };

because you can find a 0 any old place.)

Personally, I think

    $2 = (enum E) 56 Val1

is a bit hard to read.  I'd vote for something like

    $2 = (enum E)56 'Val1'

But whatever...


> Tom
>    

  parent reply	other threads:[~2010-02-03 23:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-02 22:12 patch for pr9067 Chris Moller
2010-02-02 23:28 ` Tom Tromey
2010-02-03  2:25   ` Chris Moller
2010-02-03 20:04     ` Tom Tromey
     [not found] ` <m3bpg7yznc.fsf@fleche.redhat.com>
     [not found]   ` <4B68DC25.1090808@redhat.com>
     [not found]     ` <m3fx5irwx6.fsf@fleche.redhat.com>
2010-02-03 21:52       ` PR 11067 Chris Moller
2010-02-03 22:43         ` Roland McGrath
2010-02-03 22:48           ` Tom Tromey
2010-02-03 23:14             ` Daniel Jacobowitz
2010-02-03 23:25               ` Roland McGrath
2010-02-03 23:30                 ` Daniel Jacobowitz
2010-02-03 23:34                   ` Chris Moller
2010-02-04  1:32                     ` Tom Tromey
2010-02-04 17:30                       ` Chris Moller
2010-02-04 23:53                         ` Tom Tromey
2010-02-05  0:29                           ` Chris Moller
2010-02-05 20:19                             ` Roland McGrath
2010-02-05 22:52                               ` Chris Moller
2010-02-03 23:21             ` Chris Moller [this message]
2010-02-03 22:47         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6A04DA.4040203@redhat.com \
    --to=cmoller@redhat.com \
    --cc=archer@sourceware.org \
    --cc=ebachalo@redhat.com \
    --cc=roland@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).