public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
* [binutils-gdb] libsframe: minor fixups in flip_fre related functions
@ 2023-06-01  5:58 Indu Bhagat
  0 siblings, 0 replies; only message in thread
From: Indu Bhagat @ 2023-06-01  5:58 UTC (permalink / raw)
  To: bfd-cvs, gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a5ffdcafc76c3f77c1c05fabe1544e004e9ef358

commit a5ffdcafc76c3f77c1c05fabe1544e004e9ef358
Author: Indu Bhagat <indu.bhagat@oracle.com>
Date:   Wed May 31 22:55:41 2023 -0700

    libsframe: minor fixups in flip_fre related functions
    
    libsframe/
            * sframe.c (flip_fre_start_address): Remove unnecessary type
            cast.  Use uint16_t instead of unsigned short.
            (flip_fre_stack_offsets): Likewise.

Diff:
---
 libsframe/sframe.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/libsframe/sframe.c b/libsframe/sframe.c
index dadce2c1262..97b49106e39 100644
--- a/libsframe/sframe.c
+++ b/libsframe/sframe.c
@@ -221,30 +221,28 @@ sframe_header_sanity_check_p (sframe_header *hp)
 /* Flip the start address pointed to by FP.  */
 
 static void
-flip_fre_start_address (char *fp, unsigned int fre_type)
+flip_fre_start_address (char *addr, unsigned int fre_type)
 {
-  void *start = (void*)fp;
   if (fre_type == SFRAME_FRE_TYPE_ADDR2)
     {
-      unsigned short *start_addr = (unsigned short *)(start);
+      uint16_t *start_addr = (uint16_t *)addr;
       swap_thing (*start_addr);
     }
   else if (fre_type == SFRAME_FRE_TYPE_ADDR4)
     {
-      uint32_t *start_addr = (uint32_t *)(start);
+      uint32_t *start_addr = (uint32_t *)addr;
       swap_thing (*start_addr);
     }
 }
 
 static void
-flip_fre_stack_offsets (char *fp, uint8_t offset_size, uint8_t offset_cnt)
+flip_fre_stack_offsets (char *offsets, uint8_t offset_size, uint8_t offset_cnt)
 {
   int j;
-  void *offsets = (void *)fp;
 
   if (offset_size == SFRAME_FRE_OFFSET_2B)
     {
-      unsigned short *ust = (unsigned short *)offsets;
+      uint16_t *ust = (uint16_t *)offsets;
       for (j = offset_cnt; j > 0; ust++, j--)
 	swap_thing (*ust);
     }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-06-01  5:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-01  5:58 [binutils-gdb] libsframe: minor fixups in flip_fre related functions Indu Bhagat

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).