* [binutils-gdb] libsframe: avoid using magic number
@ 2023-06-01 16:55 Indu Bhagat
0 siblings, 0 replies; only message in thread
From: Indu Bhagat @ 2023-06-01 16:55 UTC (permalink / raw)
To: bfd-cvs, gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d987df5c95340a8b41b23d68ad6a8f9f33485835
commit d987df5c95340a8b41b23d68ad6a8f9f33485835
Author: Indu Bhagat <indu.bhagat@oracle.com>
Date: Thu Jun 1 09:41:04 2023 -0700
libsframe: avoid using magic number
Define a new constant for the maximum number of stack offsets handled in
libsframe, and use it. Note that the SFrame format does not define such
a constant (limit). This is an implmentation-defined constant in
libsframe.
include/
* sframe-api.h (MAX_NUM_STACK_OFFSETS): New definition.
libsframe/
* sframe.c (sframe_fre_sanity_check_p): Use it.
Diff:
---
include/sframe-api.h | 5 ++++-
libsframe/sframe.c | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/include/sframe-api.h b/include/sframe-api.h
index 405e30c27e8..3245bc8ac90 100644
--- a/include/sframe-api.h
+++ b/include/sframe-api.h
@@ -31,7 +31,10 @@ extern "C"
typedef struct sframe_decoder_ctx sframe_decoder_ctx;
typedef struct sframe_encoder_ctx sframe_encoder_ctx;
-#define MAX_OFFSET_BYTES (SFRAME_FRE_OFFSET_4B * 2 * 3)
+#define MAX_NUM_STACK_OFFSETS 3
+
+#define MAX_OFFSET_BYTES \
+ ((SFRAME_FRE_OFFSET_4B * 2 * MAX_NUM_STACK_OFFSETS))
/* User interfacing SFrame Row Entry.
An abstraction provided by libsframe so the consumer is decoupled from
diff --git a/libsframe/sframe.c b/libsframe/sframe.c
index 97b49106e39..a97c64f7a9b 100644
--- a/libsframe/sframe.c
+++ b/libsframe/sframe.c
@@ -299,7 +299,7 @@ sframe_fre_sanity_check_p (sframe_frame_row_entry *frep)
return false;
offset_cnt = sframe_fre_get_offset_count (fre_info);
- if (offset_cnt > 3)
+ if (offset_cnt > MAX_NUM_STACK_OFFSETS)
return false;
return true;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-01 16:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-01 16:55 [binutils-gdb] libsframe: avoid using magic number Indu Bhagat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).