public inbox for binutils-cvs@sourceware.org
 help / color / mirror / Atom feed
* [binutils-gdb] use copy_private_symbol_data in objcopy
@ 2024-04-23 12:37 Alan Modra
  0 siblings, 0 replies; only message in thread
From: Alan Modra @ 2024-04-23 12:37 UTC (permalink / raw)
  To: binutils-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e13e2ba45fe23ec4e6d7335b0834290e61605d4d

commit e13e2ba45fe23ec4e6d7335b0834290e61605d4d
Author: Alan Modra <amodra@gmail.com>
Date:   Mon Apr 22 09:30:38 2024 +0930

    use copy_private_symbol_data in objcopy
    
    osympp appearing twice here is not a bug.
    
            PR 14493
            * objcopy.c (copy_object): Run the symbols through
            bfd_copy_private_symbol_data.

Diff:
---
 binutils/objcopy.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/binutils/objcopy.c b/binutils/objcopy.c
index d91ba123c01..634ebae3fc3 100644
--- a/binutils/objcopy.c
+++ b/binutils/objcopy.c
@@ -3380,6 +3380,13 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_info_type *input_arch)
       symcount = filter_symbols (ibfd, obfd, osympp, isympp, symcount);
     }
 
+  for (i = 0; i < symcount; i++)
+    if (!bfd_copy_private_symbol_data (ibfd, osympp[i], obfd, osympp[i]))
+      {
+	status = 1;
+	return false;
+      }
+
   if (dhandle != NULL)
     {
       bool res;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-04-23 12:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-23 12:37 [binutils-gdb] use copy_private_symbol_data in objcopy Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).