From: Saagar Jha <saagar@saagarjha.com>
To: binutils@sourceware.org
Subject: [PATCH] Include string.h in elf-bfd.h
Date: Sat, 5 Sep 2020 19:36:03 -0700 [thread overview]
Message-ID: <0E6E93AA-A1B9-44F2-BECB-1808058E3231@saagarjha.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
elf-bfd.h uses functions from <string.h> but doesn’t include it, which causes problems for a configure test that uses it when compiled with a compiler that is picky about missing prototypes (such as macOS’s as of recently). This patch adds the missing include.
[-- Attachment #2: Include-string.h-in-elf-bfd.h.patch --]
[-- Type: application/octet-stream, Size: 1119 bytes --]
From cdeac45356a0020c6468d7ff38e966ccbd6eb636 Mon Sep 17 00:00:00 2001
From: Saagar Jha <saagar@saagarjha.com>
Date: Thu, 13 Aug 2020 22:09:52 -0700
Subject: [PATCH] Include string.h in elf-bfd.h
Some of the configure tests include just this header, and since it uses
functions from string they fail to compile and configure thinks that
binutils is missing ELF support.
bfd/ChangeLog:
* bfd/elf-bfd.h: Include <string.h>.
---
bfd/ChangeLog | 4 ++++
bfd/elf-bfd.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 75bcf55316..26817c7e7a 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,7 @@
+2020-09-05 Saagar Jha <saagar@saagarjha.com>
+
+ * bfd/elf-bfd.h: Include <string.h>.
+
2020-09-04 Alan Modra <amodra@gmail.com>
PR 26574
diff --git a/bfd/elf-bfd.h b/bfd/elf-bfd.h
index eebdf9ac73..32ab3733be 100644
--- a/bfd/elf-bfd.h
+++ b/bfd/elf-bfd.h
@@ -26,6 +26,7 @@
#include "elf/external.h"
#include "elf/internal.h"
#include "bfdlink.h"
+#include <string.h>
#ifdef __cplusplus
extern "C" {
--
2.28.0
next reply other threads:[~2020-09-06 2:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 2:36 Saagar Jha [this message]
2020-09-07 10:04 ` Nick Clifton
2020-09-08 22:23 ` Saagar Jha
2020-09-09 12:07 ` Nick Clifton
2020-09-11 5:57 ` Saagar Jha
2020-09-14 9:55 ` Nick Clifton
2020-09-23 7:01 ` Saagar Jha
2020-09-23 9:33 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E6E93AA-A1B9-44F2-BECB-1808058E3231@saagarjha.com \
--to=saagar@saagarjha.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).