From: Nick Clifton <nickc@redhat.com>
To: Saagar Jha <saagar@saagarjha.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] Include string.h in elf-bfd.h
Date: Mon, 7 Sep 2020 11:04:03 +0100 [thread overview]
Message-ID: <8fbeb0d5-1e4b-2233-e555-a52c4afd8a36@redhat.com> (raw)
In-Reply-To: <0E6E93AA-A1B9-44F2-BECB-1808058E3231@saagarjha.com>
Hi Saagar,
> elf-bfd.h uses functions from <string.h> but doesn’t include it, which causes problems for a configure test that uses it when compiled with a compiler that is picky about missing prototypes (such as macOS’s as of recently). This patch adds the missing include.
Which configure test(s) are causing this problem ?
The inclusion of <string.h> is actually handled by "sysdep.h", which
handles the correct selection of <string.h> vs <strings.h>. No normal code
should be including elf-bfd.h without previously including that header.
Configure tests are special, since they are hand crafted, but to me this
sounds like a bug with the configure test, not the elf-bfd.h header.
Cheers
Nick
next prev parent reply other threads:[~2020-09-07 10:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 2:36 Saagar Jha
2020-09-07 10:04 ` Nick Clifton [this message]
2020-09-08 22:23 ` Saagar Jha
2020-09-09 12:07 ` Nick Clifton
2020-09-11 5:57 ` Saagar Jha
2020-09-14 9:55 ` Nick Clifton
2020-09-23 7:01 ` Saagar Jha
2020-09-23 9:33 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fbeb0d5-1e4b-2233-e555-a52c4afd8a36@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=saagar@saagarjha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).