public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Saagar Jha <saagar@saagarjha.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] Include string.h in elf-bfd.h
Date: Wed, 9 Sep 2020 13:07:10 +0100	[thread overview]
Message-ID: <5a0a8844-3b4f-b03d-60d2-a5f8b0f6c4a7@redhat.com> (raw)
In-Reply-To: <296F1157-C79B-4A4A-9F51-C1163A4E98EB@saagarjha.com>

Hi Saagar,

> but if it’s just this instance we can just include the right header in the test. Would that be “sysdep.h”?

Yes.  I am assuming that at the point where this test is run, configure will have
completed in the bfd directory and that the bfd/config.h header will have been
created.  The bfd/sysdep.h header needs that header in order to correctly choose
between <string.h> and <strings.h>.

Cheers
  Nick



  reply	other threads:[~2020-09-09 12:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-06  2:36 Saagar Jha
2020-09-07 10:04 ` Nick Clifton
2020-09-08 22:23   ` Saagar Jha
2020-09-09 12:07     ` Nick Clifton [this message]
2020-09-11  5:57       ` Saagar Jha
2020-09-14  9:55         ` Nick Clifton
2020-09-23  7:01           ` Saagar Jha
2020-09-23  9:33             ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a0a8844-3b4f-b03d-60d2-a5f8b0f6c4a7@redhat.com \
    --to=nickc@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=saagar@saagarjha.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).