From: Jan Beulich <jbeulich@suse.com>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: ☠ Buildbot (Sourceware): binutils-gdb - failed compile (failure) (master)
Date: Mon, 24 Apr 2023 12:39:43 +0200 [thread overview]
Message-ID: <0e957eb3-f117-a454-93f6-423f75cb1f2f@suse.com> (raw)
In-Reply-To: <ZEZbBSnM3Gu8FyWh@squeak.grove.modra.org>
On 24.04.2023 12:33, Alan Modra wrote:
> On Mon, Apr 24, 2023 at 08:04:35AM +0200, Jan Beulich via Binutils wrote:
>> On 24.04.2023 02:31, builder--- via Binutils wrote:
>>> - 4: make ( failure )
>>> Logs:
>>> - stdio: https://builder.sourceware.org/buildbot/#builders/77/builds/1931/steps/4/logs/stdio
>>> - warnings (8): https://builder.sourceware.org/buildbot/#builders/77/builds/1931/steps/4/logs/warnings__8_
>>
>> ../../binutils-gdb/opcodes/i386-dis.c: In function ‘print_insn’:
>> ../../binutils-gdb/opcodes/i386-dis.c:9865:22: error: storing the address of local variable ‘priv’ in ‘*info.private_data’ [-Werror=dangling-pointer=]
>> 9865 | info->private_data = &priv;
>> | ~~~~~~~~~~~~~~~~~~~^~~~~~~
>> ../../binutils-gdb/opcodes/i386-dis.c:9739:22: note: ‘priv’ declared here
>> 9739 | struct dis_private priv;
>> | ^~~~
>> ../../binutils-gdb/opcodes/i386-dis.c:9739:22: note: ‘info’ declared here
>> cc1: all warnings being treated as errors
>> make[3]: *** [Makefile:1071: i386-dis.lo] Error 1
>>
>> Which, given that this hasn't changed in a while, makes me think that a
>> new compiler was recently installed, which now diagnoses this supposed
>
> gcc-13, I expect.
After having experimented a little with godbolt.org's help (before making
the patch that you're now about to revert), I found that gcc12 is giving
this warning, too (at least in simple cases). So it may really have been
the removal of the unconditional OPCODES_SIGSETJMP() which has triggered
the warning to appear - in my playing, any unconditional function call
between the setting of the field and returning ended up masking the
warning.
Jan
>> issue (and, btw, mis-diagnoses where "info" is declared). We can't do
>> away with the assignment; it's unclear to me whether overwriting the
>> field with NULL before returning would make a difference.
>
> It does. See my other email.
>
>> Dynamically
>> allocating "priv" would be a theoretical option, but I don't view this as
>> a good one in practice.
>>
>> Thoughts, anyone?
>>
>> Jan
>
next prev parent reply other threads:[~2023-04-24 10:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 0:31 builder
2023-04-24 6:04 ` Jan Beulich
2023-04-24 10:33 ` Alan Modra
2023-04-24 10:39 ` Jan Beulich [this message]
2023-04-24 11:48 ` Mark Wielaard
-- strict thread matches above, loose matches on Subject: below --
2024-04-23 18:52 builder
2024-01-29 19:38 builder
2024-01-22 0:59 builder
2024-01-16 11:31 builder
2024-01-16 10:22 builder
2023-12-29 7:43 builder
2023-11-24 9:13 builder
2023-10-13 14:40 builder
2023-10-13 14:48 ` Clément Chigot
2023-10-06 20:07 builder
2023-09-25 9:56 builder
2023-09-25 9:22 builder
2023-08-18 17:45 builder
2023-08-02 9:02 builder
2023-07-27 14:32 builder
2023-07-21 12:06 builder
2023-07-19 0:43 builder
2023-05-26 9:02 builder
2023-05-26 7:16 builder
2023-05-23 6:10 builder
2023-04-21 13:56 builder
2023-04-14 0:30 builder
2023-03-31 6:44 builder
2023-03-07 16:17 builder
2023-01-17 11:46 builder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e957eb3-f117-a454-93f6-423f75cb1f2f@suse.com \
--to=jbeulich@suse.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).