From: Eric Christopher <echristo@redhat.com>
To: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>, binutils@sources.redhat.com
Subject: Re: [PATCH] MIPS gas: Fix macro expansions for .set noat
Date: Thu, 17 Feb 2005 13:53:00 -0000 [thread overview]
Message-ID: <1108624232.4149.13.camel@localhost.localdomain> (raw)
In-Reply-To: <20050217002446.GJ1757@rembrandt.csv.ica.uni-stuttgart.de>
> Hm, OTOH it could simply be sloppy coding, and falling over it
> is not necessarily the right thing to do. I plan to commit the
> appended patch, it partially reverts the earlier change.
>
> Comments?
>
>
> Thiemo
>
>
> 2005-02-16 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
>
> /gas/ChangeLog
> * config/tc-mips.c (macro): Don't fail but warn on $at uses
> after .set noat, it may only be sloppy coding. Don't try to
> avoid $at use by sacrificing the target register before it is
> stored, it won't work.
Actually I disagree. If the user used .set noat and has sloppy coding we
should fall over like we would for .set nomacro or such.
-eric
next prev parent reply other threads:[~2005-02-17 7:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-16 23:51 Thiemo Seufer
2005-02-17 0:25 ` Maciej W. Rozycki
2005-02-17 1:31 ` Maciej W. Rozycki
2005-02-17 1:34 ` Thiemo Seufer
2005-02-17 2:02 ` Maciej W. Rozycki
2005-02-17 7:10 ` Thiemo Seufer
2005-02-17 13:53 ` Eric Christopher [this message]
2005-02-17 20:50 ` Maciej W. Rozycki
2005-02-17 21:33 ` Thiemo Seufer
2005-02-18 0:21 ` Maciej W. Rozycki
2005-02-21 2:57 ` Thiemo Seufer
2005-02-18 23:01 ` Eric Christopher
2005-02-21 8:21 ` Thiemo Seufer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1108624232.4149.13.camel@localhost.localdomain \
--to=echristo@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=ica2_ts@csv.ica.uni-stuttgart.de \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).